Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish v0.20.0 of package:intl #909

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Publish v0.20.0 of package:intl #909

merged 2 commits into from
Nov 11, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Nov 11, 2024

Fixes #908
Fixes #793


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Nov 11, 2024

Package publishing

Package Version Status Publish tag (post-merge)
package:intl 0.20.0 ready to publish intl-v0.20.0
package:intl4x 0.10.1 already published at pub.dev
package:intl_translation 0.20.1-wip WIP (no publish necessary)
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
intl None 0.20.0-wip 0.20.0 0.20.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
intl StringStack
DateBuilder

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/messages/examples_flutter/my_application/lib/src/empty_de.dart
pkgs/messages/examples_flutter/my_application/lib/src/empty_en.dart

@mosuem mosuem requested a review from devoncarew November 11, 2024 08:18
@mosuem mosuem enabled auto-merge (squash) November 11, 2024 08:18
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Do we also want to widen the dep range on intl from https://github.com/dart-lang/i18n/blob/main/pkgs/intl_translation/pubspec.yaml#L20, and publish that package?

We should also pre-create a 'version solving failed for 0.20.0 ...' issue, pin it, and un-pin the old one.

@mosuem mosuem merged commit 9314522 into main Nov 11, 2024
13 checks passed
@mosuem mosuem deleted the publishIntl branch November 11, 2024 16:07
copybara-service bot pushed a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants