Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMPMS String list for "ko" DateSymbols must be ['오전', '오후'] not ['AM', 'PM'] #793

Closed
JakeSeo opened this issue Feb 7, 2024 · 3 comments · Fixed by #794 or #909
Closed
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:intl type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@JakeSeo
Copy link

JakeSeo commented Feb 7, 2024

Describe the bug
In intl 0.19.0, the DateSymbols for certain locale has wrong values. The AMPMS String list for "ko" DateSymbols must be ['오전', '오후'] not ['AM', 'PM']. It was ok in v 0.18. There might be other wrong values for other locales. Please check.

To Reproduce
Add a minimal working example or, if not possible or available, any code which might help to reproduce the problem

// in date_symbol_data_local.dart file
"ko": new DateSymbols(
...
AMPMS: const ['AM', 'PM'], // must be ['오전', '오후']
...
),

System info

% flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.16.9, on macOS 13.6.2 22G320 darwin-arm64, locale en-KR)
@JakeSeo JakeSeo added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Feb 7, 2024
@mosuem mosuem added package:intl P1 A high priority bug; for example, a single project is unusable or has many test failures labels Feb 7, 2024
@mosuem
Copy link
Member

mosuem commented Feb 7, 2024

This is indeed a regression due to a change in generating scripts. The AM/PM keys were switched to taking the "abbreviated" instead of the "wide" version of the dayPeriodWidth in the CLDR data, but for Korean, there is no "abbreviated" version, leading to the AM/PM fallback.

@p1318k
Copy link

p1318k commented Oct 18, 2024

@mosuem this issue is reproducible on the latest version 0.19.0.
Regression code may applied again.

@mosuem mosuem reopened this Oct 18, 2024
@isairz
Copy link

isairz commented Nov 8, 2024

@mosuem
The issue regarding incorrect 'AM' and 'PM' symbols was resolved nine months ago. However, a new version incorporating this fix has not yet been released. I hope for a prompt release of the updated version(0.20.0) to resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:intl type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants