Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer write the dartdoc version into generated html files #3624

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

devoncarew
Copy link
Member


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@kevmoo
Copy link
Member

kevmoo commented Jan 19, 2024

If we're going to mess with this, would it be better to be a bit less cute and a bit more helpful

Either point to the pub.dev page or github repo?

Copy link
Member

@kallentu kallentu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with these changes, but was there a reason that we were doing this in the first place?

@devoncarew
Copy link
Member Author

If we're going to mess with this, would it be better to be a bit less cute and a bit more helpful Either point to the pub.dev page or github repo?

I think we could just remove this line entirely honestly:

<meta name="generator" content="made with love by dartdoc"

I'm good with these changes, but was there a reason that we were doing this in the first place?

I think this is purely historical and not for any particular use case; @srawlins or @keertip may know more.

@parlough
Copy link
Member

parlough commented Jan 19, 2024

I imagine the original idea was to quickly identify what version of dartdoc a site was generated with in case there are any issues to report or track down.

I think it's probably fine to drop the entire metadata though. I've never ended up using it :P

@devoncarew
Copy link
Member Author

FYI, I updated this PR to remove the 'made with dartdoc' html comment entirely.

@devoncarew devoncarew merged commit d2d4cc9 into dart-lang:main Jan 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants