Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues rolling the latest dartdoc into google3 #3562

Closed
devoncarew opened this issue Oct 30, 2023 · 3 comments
Closed

issues rolling the latest dartdoc into google3 #3562

devoncarew opened this issue Oct 30, 2023 · 3 comments
Labels
customer-google3 Issues originating from or important to Angular P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@devoncarew
Copy link
Member

We're seeing issues rolling the current dartdoc into google3:

https://fusion2.corp.google.com/invocations/a94742f7-0a21-4518-b126-ad4f8a028292/targets/%2F%2Fdart%2Fdartdoc:dartdoc_e2e_test_run/tests

//dart/dartdoc:dartdoc_e2e_test_run

It looks like some golden test files might need to be regenerated:

Expected: '<!DOCTYPE html>\n'...
Expected: '<!DOCTYPE html>\n'
            '<html lang="en">\n'
            '<head>\n'
            '  <meta charset="utf-8">\n'
            '  <meta http-equiv="X-UA-Compatible" content="IE=edge">\n'
            '  <meta name="viewport" content="width=device-width, height=device-height, initial-scale=1, user-
...
@devoncarew
Copy link
Member Author

Ah, on closer inspection:

   Which: is different.
          Expected: ... rtdoc 7.0.1">\n  <me ...
            Actual: ... rtdoc 7.0.2">\n  <me ...
                                  ^

We may want to make that test not depend on the specific version text.

@srawlins
Copy link
Member

We may want to make that test not depend on the specific version text.

+1. I'd prefer to delete those golden tests in favor of unit tests.

@pq pq added P1 A high priority bug; for example, a single project is unusable or has many test failures customer-google3 Issues originating from or important to Angular labels Nov 1, 2023
@devoncarew devoncarew mentioned this issue Jan 19, 2024
Merged
1 task
@devoncarew
Copy link
Member Author

fixed in association with b/321827375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer-google3 Issues originating from or important to Angular P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pq @srawlins @devoncarew