Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run flutter pub get when appropriate instead of normal pub get #2190

Merged
merged 4 commits into from
Apr 23, 2020
Merged

Run flutter pub get when appropriate instead of normal pub get #2190

merged 4 commits into from
Apr 23, 2020

Conversation

jcollins-g
Copy link
Contributor

Found while looking into #2128, we're running the wrong flutter pub get and not using the right detection for a need to run pub get. This fixes both.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Apr 22, 2020
@coveralls
Copy link

coveralls commented Apr 23, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 91.591% when pulling 908197d on pubgetfix into 18fdf4a on master.

srawlins
srawlins approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I like the grinder changes, dart_tool changes.

@jcollins-g
Copy link
Contributor Author

Thanks. I got burned by having package_config.jsons littering the tree for the last time :-D

@jcollins-g jcollins-g merged commit 3cba934 into master Apr 23, 2020
@jcollins-g jcollins-g deleted the pubgetfix branch April 27, 2020 20:40
srawlins added a commit to srawlins/dartdoc that referenced this pull request Aug 24, 2020
@srawlins
Improve error when FLUTTER_ROOT is missing.
b0b6058 
This is a re-do, sort of, of dart-lang#1714, which was broken in dart-lang#2190.
@srawlins srawlins mentioned this pull request Aug 24, 2020
Merged
srawlins added a commit that referenced this pull request Aug 27, 2020
@srawlins
Improve error when FLUTTER_ROOT is missing. (#2316)
977f765 
This is a re-do, sort of, of #1714, which was broken in #2190.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

@stereotype441 stereotype441 Awaiting requested review from stereotype441

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcollins-g @coveralls @srawlins @googlebot