Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flutter root exception #1714

Merged
merged 9 commits into from
Jun 14, 2018
Merged

Fix flutter root exception #1714

merged 9 commits into from
Jun 14, 2018

Conversation

jcollins-g
Copy link
Contributor

Fixes #1705. Produces a much nicer error message when FLUTTER_ROOT is not set:

~/dart/dartdoc/testing/test_package_flutter_plugin
$ dart ../../bin/dartdoc.dart
Generating documentation for 'test_package_flutter_plugin' into /usr/local/google/home/jcollins/dart/dartdoc/testing/test_package_flutter_plugin/doc/api/
parsing lib/testlib.dart...
parsing /usr/local/google/home/jcollins/.dartdoc_grinder/cleanFlutter/bin/cache/pkg/sky_engine/lib/collection/collection.dart...
parsing /usr/local/google/home/jcollins/.dartdoc_grinder/cleanFlutter/bin/cache/pkg/sky_engine/lib/developer/developer.dart...
parsing /usr/local/google/home/jcollins/.dartdoc_grinder/cleanFlutter/bin/cache/pkg/sky_engine/lib/internal/internal.dart...
parsing /usr/local/google/home/jcollins/.dartdoc_grinder/cleanFlutter/bin/cache/pkg/sky_engine/lib/io/io.dart...
parsing /usr/local/google/home/jcollins/.dartdoc_grinder/cleanFlutter/bin/cache/pkg/sky_engine/lib/isolate/isolate.dart...
parsing /usr/local/google/home/jcollins/.dartdoc_grinder/cleanFlutter/bin/cache/pkg/sky_engine/lib/async/async.dart...
parsing /usr/local/google/home/jcollins/.dartdoc_grinder/cleanFlutter/bin/cache/pkg/sky_engine/lib/convert/convert.dart...
parsing /usr/local/google/home/jcollins/.dartdoc_grinder/cleanFlutter/bin/cache/pkg/sky_engine/lib/typed_data/typed_data.dart...
parsing /usr/local/google/home/jcollins/.dartdoc_grinder/cleanFlutter/bin/cache/pkg/sky_engine/lib/_empty.dart...
parsing /usr/local/google/home/jcollins/.dartdoc_grinder/cleanFlutter/bin/cache/pkg/sky_engine/lib/math/math.dart...
parsing /usr/local/google/home/jcollins/.dartdoc_grinder/cleanFlutter/bin/cache/pkg/sky_engine/lib/core/core.dart...
parsing /usr/local/google/home/jcollins/.dartdoc_grinder/cleanFlutter/bin/cache/pkg/sky_engine/lib/_http/http.dart...
parsing /usr/local/google/home/jcollins/.dartdoc_grinder/cleanFlutter/bin/cache/pkg/sky_engine/lib/ui/ui.dart...

Generation failed: Top level package requires Flutter but FLUTTER_ROOT environment variable not set.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jun 13, 2018
@jcollins-g jcollins-g requested review from devoncarew and pq and removed request for devoncarew June 14, 2018 19:17
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcollins-g jcollins-g merged commit 6241b55 into master Jun 14, 2018
@jcollins-g jcollins-g deleted the fix-flutter-root-exception branch June 14, 2018 22:15
srawlins added a commit to srawlins/dartdoc that referenced this pull request Aug 24, 2020
This is a re-do, sort of, of dart-lang#1714, which was broken in dart-lang#2190.
srawlins added a commit that referenced this pull request Aug 27, 2020
This is a re-do, sort of, of #1714, which was broken in #2190.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants