Skip to content

Commit

Permalink
[build] revert Kotlin version to 1.3.72 (ExpediaGroup#858)
Browse files Browse the repository at this point in the history
We are hitting some library and plugin issues with incompatibilities between Kotlin versions. Downgrading back to 1.3.72 for now, we will revisit update to 1.4 sometime in the future.
  • Loading branch information
dariuszkuc authored Sep 1, 2020
1 parent 5dd2925 commit cfe42bf
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ org.gradle.jvmargs=-Xmx2g -XX:MaxPermSize=512m -XX:+HeapDumpOnOutOfMemoryError

# dependencies
kotlinJvmVersion = 1.8
kotlinVersion = 1.4.0
kotlinCoroutinesVersion = 1.3.9
kotlinVersion = 1.3.72
kotlinCoroutinesVersion = 1.3.8

classGraphVersion = 4.8.87
graphQLJavaVersion = 15.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ abstract class GraphQLGradlePluginAbstractIT {
// unsure if there is a better way - correct values are set from Gradle build
// when running directly from IDE you will need to manually update those to correct values
private val gqlKotlinVersion = System.getProperty("graphQLKotlinVersion") ?: "4.0.0-SNAPSHOT"
private val kotlinVersion = System.getProperty("kotlinVersion") ?: "1.4.0"
private val kotlinVersion = System.getProperty("kotlinVersion") ?: "1.3.72"
private val junitVersion = System.getProperty("junitVersion") ?: "5.6.2"

val testSchema = loadResource("mocks/schema.graphql")
Expand Down
1 change: 0 additions & 1 deletion plugins/graphql-kotlin-maven-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ dependencies {
implementation("org.apache.maven:maven-plugin-api:$mavenPluginApiVersion")
implementation("org.apache.maven:maven-project:$mavenProjectVersion")
implementation("org.apache.maven.plugin-tools:maven-plugin-annotations:$mavenPluginAnnotationVersion")
testImplementation(project(path = ":graphql-kotlin-client"))
}

tasks {
Expand Down

0 comments on commit cfe42bf

Please sign in to comment.