Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] revert Kotlin version to 1.3.72 #858

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

dariuszkuc
Copy link
Collaborator

📝 Description

We are hitting some library and plugin issues with incompatibilities between Kotlin versions. Downgrading back to 1.3.72 for now, we will revisit update to 1.4 sometime in the future.

🔗 Related Issues

Update to 1.4 #844

We are hitting some library and plugin issues with incompatibilities between Kotlin versions. Downgrading back to 1.3.72 for now, we will revisit update to 1.4 sometime in the future.
@dariuszkuc
Copy link
Collaborator Author

I'll update the examples in subsequent PR once we release another version.

@smyrick smyrick merged commit 10d3ad2 into ExpediaGroup:master Sep 1, 2020
@dariuszkuc dariuszkuc deleted the kotlin_1.3 branch September 1, 2020 04:08
@pjwalstrom
Copy link
Contributor

was this due to FasterXML/jackson-module-kotlin#356?

@dariuszkuc
Copy link
Collaborator Author

@pjwalstrom We generally don't use inline classes for schema generation so that one wasn't problematic. I did encounter another issue (FasterXML/jackson-databind#2821) but that is happening regardless of Kotlin version.

I was getting issues with Gradle including https://issuetracker.google.com/issues/166582569 and https://youtrack.jetbrains.com/issue/KT-37435 that was blowing up when using our plugin in a separate project (unsure why integration tests worked).

@smyrick smyrick added changes: patch Changes require a patch version type: dependency changes Dependency change which doesn't affect our library usage labels Sep 1, 2020
huehnerlady pushed a commit to huehnerlady/graphql-kotlin that referenced this pull request Oct 16, 2020
We are hitting some library and plugin issues with incompatibilities between Kotlin versions. Downgrading back to 1.3.72 for now, we will revisit update to 1.4 sometime in the future.
@smyrick smyrick added this to the 4.0.0 milestone Dec 27, 2020
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
We are hitting some library and plugin issues with incompatibilities between Kotlin versions. Downgrading back to 1.3.72 for now, we will revisit update to 1.4 sometime in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: patch Changes require a patch version type: dependency changes Dependency change which doesn't affect our library usage
Development

Successfully merging this pull request may close these issues.

3 participants