-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow authoring support #563
Conversation
more updates update durabletask-js version init workflow support Signed-off-by: kaibocai <[email protected]>
Signed-off-by: kaibocai <[email protected]>
Signed-off-by: kaibocai <[email protected]>
7328d00
to
3a2649f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, please also fix the linting issues.
improve workflow unit test Signed-off-by: kaibocai <[email protected]>
3989514
to
781a620
Compare
Signed-off-by: kaibocai <[email protected]>
Signed-off-by: kaibocai <[email protected]>
Signed-off-by: kaibocai <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
===========================================
+ Coverage 35.36% 55.79% +20.43%
===========================================
Files 95 14 -81
Lines 10570 319 -10251
Branches 452 63 -389
===========================================
- Hits 3738 178 -3560
+ Misses 6745 124 -6621
+ Partials 87 17 -70 ☔ View full report in Codecov by Sentry. |
Signed-off-by: kaibocai <[email protected]>
0b0d5c4
to
378dfe2
Compare
Signed-off-by: kaibocai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kaibocai, please add docs to the PR too!
Signed-off-by: kaibocai <[email protected]>
Signed-off-by: kaibocai <[email protected]>
Signed-off-by: kaibocai <[email protected]>
Signed-off-by: kaibocai <[email protected]>
Signed-off-by: kaibocai <[email protected]>
Signed-off-by: kaibocai <[email protected]>
Signed-off-by: kaibocai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall now, @kaibocai could you see the warnings?
Signed-off-by: kaibocai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR and great work @kaibocai! This will greatly benefit JS SDK users who have been wanting to try out authoring Dapr Workflow!
Signed-off-by: kaibocai <[email protected]>
Description
This PR initiates the support for dapr workflow.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #463 and #545
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
cc @cgillum, @rabollin, @torosent