fix warnings - remove unused dependencies

Signed-off-by: kaibocai <[email protected]>
dapr · Jan 16, 2024 · 6fb6544 · 6fb6544
1 parent 50b4b7d
commit 6fb6544
Show file tree

Hide file tree

Showing 4 changed files with 80 additions and 36 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -62,7 +62,6 @@
     "@types/express": "^4.17.15",
     "@types/jest": "^27.0.1",
     "@types/node": "^16.9.1",
-    "@types/readline-sync": "^1.4.8",
     "@types/uuid": "^8.3.1",
     "@typescript-eslint/eslint-plugin": "^5.1.0",
     "@typescript-eslint/parser": "^5.1.0",
@@ -77,7 +76,6 @@
     "prettier": "^2.4.0",
     "pretty-quick": "^3.1.3",
     "ts-jest": "^27.0.5",
-    "ts-node": "^10.9.1",
     "typescript": "^4.5.5"
   },
   "repository": {

diff --git a/src/workflow/internal/index.ts b/src/workflow/internal/index.ts
@@ -30,7 +30,15 @@ import { GrpcEndpoint } from "../../network/GrpcEndpoint";
  * @typeparam TOutput - The type of the output for the workflow activity.
  */
 export function getFunctionName(fn: TWorkflow | TWorkflowActivity<TInput, TOutput>): string {
-  return fn.name || fn.toString().match(/function\s*([^(]*)\(/)![1];
+  if (fn.name) {
+    return fn.name;
+  } else {
+    const match = fn.toString().match(/function\s*([^(]*)\(/);
+    if (match === null) {
+      throw new Error("Unable to determine function name, try to sepecify the workflow/activity name explicitly.");
+    }
+    return match[1];
+  }
 }
 
 /**

diff --git a/test/e2e/workflow/workflow.test.ts b/test/e2e/workflow/workflow.test.ts
@@ -199,7 +199,7 @@ describe("Workflow", () => {
       expectedCompletionSecond += delay * 1000;
     }
     expect(expectedCompletionSecond).toBeDefined();
-    const actualCompletionSecond = state?.lastUpdatedAt?.getTime();
+    const actualCompletionSecond = state?.lastUpdatedAt?.getTime() ?? 0;
     expect(actualCompletionSecond).toBeDefined();
 
     expect(state).toBeDefined();
@@ -209,7 +209,7 @@ describe("Workflow", () => {
     expect(state?.runtimeStatus).toEqual(WorkflowRuntimeStatus.COMPLETED);
     expect(state?.createdAt).toBeDefined();
     expect(state?.lastUpdatedAt).toBeDefined();
-    expect(expectedCompletionSecond).toBeLessThanOrEqual(actualCompletionSecond!);
+    expect(expectedCompletionSecond).toBeLessThanOrEqual(actualCompletionSecond);
   }, 31000);
 
   it("should wait for external events with a timeout - true", async () => {