Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wait for sidecar docs & update java-sdk docs to match .net more w… #981

Merged
merged 5 commits into from
Jan 8, 2024

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented Jan 5, 2024

Description

add wait for sidecar and shutdown docs to sdk docs page. also updated file name to match docs requirement here, stating files/folders should start w/ java-. I also added Available packages to the landing page for the java sdk docs (in line w/ dotnet landing page). I also changed the java-workflow.md to be java-workflow-howto.md since that is how dotnet had it.

image
image
image
image

Issue reference

docs for: #918

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@cicoyle cicoyle requested review from a team as code owners January 5, 2024 17:57
@cicoyle cicoyle requested review from hhunter-ms and a team and removed request for a team January 5, 2024 17:57
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c312bd) 76.29% compared to head (500a4ea) 76.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #981   +/-   ##
=========================================
  Coverage     76.29%   76.29%           
  Complexity     1463     1463           
=========================================
  Files           138      138           
  Lines          4497     4497           
  Branches        524      524           
=========================================
  Hits           3431     3431           
  Misses          784      784           
  Partials        282      282           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@artursouza artursouza merged commit 657fc37 into dapr:master Jan 8, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants