Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Migrate waitForSidecar to v1.0/healthz/outbound to provide parity with dotnet SDK #897

Closed
olitomlinson opened this issue Aug 30, 2023 · 2 comments
Assignees

Comments

@olitomlinson
Copy link

olitomlinson commented Aug 30, 2023

Describe the proposal

In my opinion, the dotnet SDK provides a more explicit implementation that is better isolated from accidental change.

For example, if the ordering of a dapr runtime init ever changed (accidentally or deliberately), and the dapr http port was open before all components were initialised, then this would cause a break in behaviour.

Therefore, for this reason, I propose that the Java SDK (and other SDKs) should follow the same behaviour as the dotnet SDK and wait for a successful response from v1.0/healthz/outbound rather than just waiting for the dapr http port to be open.


This is my understanding of the relationship between Dapr and the App during init

image

@olitomlinson olitomlinson changed the title [Proposal] Migrate waitForSidecar to v1.0/healthz/outbound to maintain parity with dotnet SDK [Proposal] Migrate waitForSidecar to v1.0/healthz/outbound to provide parity with dotnet SDK Aug 30, 2023
@cicoyle
Copy link
Contributor

cicoyle commented Sep 21, 2023

/assign

@cicoyle
Copy link
Contributor

cicoyle commented Jan 5, 2024

once the docs PR I have open gets merged, then this issue can be closed.

@cicoyle cicoyle closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants