Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated actor configuration #914

Merged
merged 22 commits into from
Oct 2, 2023

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented Sep 14, 2023

Description

Opened this PR since I didn't have permission to push to MregXN's fork to update his PR here.

All I've done is merge in master.

Issue reference

Will close: #892

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@cicoyle
Copy link
Contributor Author

cicoyle commented Sep 22, 2023

Im reviewing sdk-actors/src/test/java/io/dapr/actors/runtime/ActorRuntimeTest.java bc it looks weird now after the merge ---> this is done now

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (96c0418) 76.19% compared to head (8bdf3cd) 76.40%.
Report is 1 commits behind head on master.

❗ Current head 8bdf3cd differs from pull request most recent head 91c413d. Consider uploading reports for the commit 91c413d to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #914      +/-   ##
============================================
+ Coverage     76.19%   76.40%   +0.21%     
- Complexity     1433     1453      +20     
============================================
  Files           135      136       +1     
  Lines          4399     4451      +52     
  Branches        518      526       +8     
============================================
+ Hits           3352     3401      +49     
+ Misses          766      764       -2     
- Partials        281      286       +5     
Files Coverage Δ
...ava/io/dapr/actors/runtime/ActorRuntimeConfig.java 100.00% <100.00%> (+8.69%) ⬆️
...n/java/io/dapr/actors/runtime/ActorTypeConfig.java 90.90% <90.90%> (ø)
.../io/dapr/actors/runtime/ActorObjectSerializer.java 85.32% <75.00%> (+0.61%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artursouza artursouza merged commit b6514bb into dapr:master Oct 2, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants