Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Per Actor Type Configuration #729

Closed
halspang opened this issue Apr 7, 2022 · 4 comments
Closed

Add Support for Per Actor Type Configuration #729

halspang opened this issue Apr 7, 2022 · 4 comments
Assignees
Labels
good first issue Good for newcomers kind/enhancement-runtime-dependency New feature or request due to a runtime feature P1
Milestone

Comments

@halspang
Copy link
Contributor

halspang commented Apr 7, 2022

Describe the proposal

The Dapr Runtime added support for per actor type configurations in 1.7. This support needs to be added to the SDKs.

The new configuration looks like:

{
  "entities":["actorType1", "actorType2"],
  "actorIdleTimeout": "1h",
  "actorScanInterval": "30s",
  "drainOngoingCallTimeout": "30s",
  "drainRebalancedActors": true,
  "reentrancy": {
    "enabled": true,
    "maxStackDepth": 32
  },
  "entitiesConfig": [
      {
          "entities": ["actorType1"],
          "actorIdleTimeout": "1m",
          "drainOngoingCallTimeout": "10s",
          "reentrancy": {
              "enabled": false
          }
      }
  ]
}

Implementation can be varied per SDK but should output to the above JSON.

Docs: dapr/docs#2334
Runtime: dapr/dapr#4201

@artursouza artursouza added this to the v1.6 milestone Apr 20, 2022
@skyao
Copy link
Member

skyao commented Apr 20, 2022

/assign

@msfussell msfussell added the kind/enhancement-runtime-dependency New feature or request due to a runtime feature label Jun 8, 2022
@artursouza artursouza modified the milestones: v1.6, v1.7 Jun 23, 2022
@artursouza artursouza modified the milestones: v1.7, v1.8 Sep 30, 2022
@artursouza artursouza added the P1 label Nov 7, 2022
@artursouza artursouza added the good first issue Good for newcomers label Nov 7, 2022
@artursouza artursouza modified the milestones: v1.8, v1.9 Feb 1, 2023
@artursouza artursouza modified the milestones: v1.9, v1.10 May 25, 2023
@MregXN
Copy link
Member

MregXN commented Aug 22, 2023

/assign

@artursouza
Copy link
Member

Fixed in #914

@cicoyle
Copy link
Contributor

cicoyle commented Oct 6, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement-runtime-dependency New feature or request due to a runtime feature P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants