-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRE-2507 common: do not report "Doc-only: true" for empty commit #446
Conversation
Signed-off-by: Tomasz Gromadzki <[email protected]>
83b0eae
to
db97154
Compare
TO BE REMOVED BEFORE LANDING Signed-off-by: Tomasz Gromadzki <[email protected]>
Jenkinsfile
Outdated
@@ -18,6 +18,7 @@ | |||
// Then a second PR submitted to comment out the @Library line, and when it | |||
// is landed, both PR branches can be deleted. | |||
//@Library(value='pipeline-lib@my_branch_name') _ | |||
@Library(value="pipeline-lib@grom72/SRE-2507") _ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be removed before landing.
db97154
to
b1f6fef
Compare
This reverts commit b1f6fef. Signed-off-by: Tomasz Gromadzki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it should work for the *-testing branches. Do we want some similar logic in the ci/doc_only_change.sh
file in the daos master/release branches to allow emty commity PRs to run tests w/o a commit pragma?
Not yet. But let's wait until 2.6.1 is ready. |
Empty commit shall not be treated as
Doc-only: true
Fix the problem introduced by #444:
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/daily-2.6-testing/114/console