Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRE-2507 common: do not report "Doc-only: true" for empty commit #446

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Sep 24, 2024

Empty commit shall not be treated as Doc-only: true

Fix the problem introduced by #444:

https://build.hpdd.intel.com/job/daos-stack/job/daos/job/daily-2.6-testing/114/console

14:00:27  + TARGET_BRANCH=daily-2.6-testing
14:00:27  + set -uex
14:00:27  + git fetch origin daily-2.6-testing
14:00:27  From https://github.com/daos-stack/daos
14:00:27   * branch                daily-2.6-testing -> FETCH_HEAD
14:00:27  + git diff --no-commit-id --name-only origin/daily-2.6-testing HEAD
14:00:27  + grep -v -e '^docs/' -e '\.md$' -e '^.*LICENSE.*$'
14:00:27  Stage "Test" skipped due to when conditional

TO BE REMOVED BEFORE LANDING

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72 grom72 marked this pull request as ready for review September 24, 2024 15:51
@grom72 grom72 marked this pull request as draft September 24, 2024 15:51
Jenkinsfile Outdated
@@ -18,6 +18,7 @@
// Then a second PR submitted to comment out the @Library line, and when it
// is landed, both PR branches can be deleted.
//@Library(value='pipeline-lib@my_branch_name') _
@Library(value="pipeline-lib@grom72/SRE-2507") _
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed before landing.

@grom72 grom72 marked this pull request as ready for review September 24, 2024 15:58
This reverts commit b1f6fef.

Signed-off-by: Tomasz Gromadzki <[email protected]>
phender
phender previously approved these changes Sep 24, 2024
Copy link
Contributor

@phender phender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it should work for the *-testing branches. Do we want some similar logic in the ci/doc_only_change.sh file in the daos master/release branches to allow emty commity PRs to run tests w/o a commit pragma?

@grom72
Copy link
Contributor Author

grom72 commented Sep 24, 2024

It looks like it should work for the *-testing branches. Do we want some similar logic in the ci/doc_only_change.sh file in the daos master/release branches to allow emty commity PRs to run tests w/o a commit pragma?

Not yet. But let's wait until 2.6.1 is ready.

@brianjmurrell brianjmurrell merged commit dd28809 into master Sep 24, 2024
9 of 10 checks passed
@brianjmurrell brianjmurrell deleted the grom72/SRE-2507 branch September 24, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants