Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRE-2509 common: do not skip tests on empty commits #15199

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Sep 26, 2024

ci/doc_only_change.sh shall not return 1 if it detects no changes since the last execution (or reference branch).

"Doc-only: false" is no longer needed to fix this problem

Additionally, the LICENSE file is treated as documentation.

See: daos-stack/pipeline-lib#446

Signeed-off-by: Tomasz Gromadzki [email protected]

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/SRE-2509

ci/doc_only_change.sh shall not return 1 if it detects
no changes since the last execution (or reference branch).

"Doc-only: false" is no longer needed to fix this problem

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72 grom72 requested a review from a team October 8, 2024 05:58
@daltonbohning daltonbohning merged commit dbc2808 into master Oct 8, 2024
79 of 80 checks passed
@daltonbohning daltonbohning deleted the grom72/SRE-2509 branch October 8, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants