Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16100 test: Fix stopping daos_test during timeout (#15275) #15603

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented Dec 11, 2024

Fix stopping timed out processes run by a JobManager class by only searching for and killing the command executable being run by clush, orterun, mpirun, etc. Add a new harness/cmocka.py test to verify the stopping of the processes with a test timeout.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr daos_test dfuse_test test_load_mpi HarnessCmockaTest
Allow-unstable-test: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Fix stopping timed out processes run by a JobManager class by only
searching for and killing the command executable being run by clush,
orterun, mpirun, etc. Add a new harness/cmocka.py test to verify the
stopping of the processes with a test timeout.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr daos_test dfuse_test test_load_mpi HarnessCmockaTest
Allow-unstable-test: true

Signed-off-by: Phil Henderson <[email protected]>
@phender phender requested review from a team as code owners December 11, 2024 21:53
@phender phender added clean-cherry-pick Cherry-pick from another branch that did not require additional edits release-2.6.3 Targeted for 2.6.3 labels Dec 11, 2024
Copy link

Ticket title is 'daos_test/suite.py:DaosCoreTest.test_daos_degraded_ec - cart_ctl error due to errored rank 0'
Status is 'Awaiting backport'
Labels: '2.6.0rc1,ci_impact,pr_test,tcp_provider,testp2'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16100

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Dec 11, 2024
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15603/1/execution/node/825/log

@phender
Copy link
Contributor Author

phender commented Dec 12, 2024

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15603/1/execution/node/825/log

The harness/cmocka.py test failures are expected.

@phender phender requested a review from a team December 12, 2024 14:33
@phender phender merged commit 7f1eab0 into release/2.6 Dec 12, 2024
45 of 49 checks passed
@phender phender deleted the hendersp/DAOS-16100 branch December 12, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed) release-2.6.3 Targeted for 2.6.3
Development

Successfully merging this pull request may close these issues.

3 participants