Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b/360833010 disable punch and stat collectives #14974

Merged
merged 1 commit into from
Aug 21, 2024
Merged

b/360833010 disable punch and stat collectives #14974

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/object/cli_mod.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ dc_obj_init(void)
if (rc != 0)
goto out_class;

obj_coll_thd = OBJ_COLL_THD_MIN;
obj_coll_thd = 0; /* Was OBJ_COLL_THD_MIN, restore when leak is fixed */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit: I really prefer to put some kind of tracker for these kinds of TODO/FIXME changes. e.g. /* FIXME b/360833010: Restore to OBJ_COLL_THD_MIN when leak fixed */

Even better, use a new bug that can be closed when the FIXME is reverted. We do that a lot in the control plane code. Makes it harder to forget when there's an open ticket that gets looked at during planning.

d_getenv_uint("DAOS_OBJ_COLL_THD", &obj_coll_thd);
if (obj_coll_thd == 0) {
D_INFO("Disable collective operation.\n");
Expand Down
Loading