Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b/360833010 disable punch and stat collectives #14974

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

jolivier23
Copy link
Contributor

There appears to be a leak with punch and stat collectives so let's disable them by default. We can use the environment variable to test fixes and possibly revert this later.

Required-githooks: true

Change-Id: I21588d20416bd3f7c24cf56ef8e059216d654503

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

There appears to be a leak with punch and stat collectives
so let's disable them by default.  We can use the environment
variable to test fixes and possibly revert this later.

Required-githooks: true

Change-Id: I21588d20416bd3f7c24cf56ef8e059216d654503
Signed-off-by: Jeff Olivier <[email protected]>
Copy link

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/b/360833010

@jolivier23 jolivier23 requested a review from mjmac August 21, 2024 13:23
@@ -186,7 +186,7 @@ dc_obj_init(void)
if (rc != 0)
goto out_class;

obj_coll_thd = OBJ_COLL_THD_MIN;
obj_coll_thd = 0; /* Was OBJ_COLL_THD_MIN, restore when leak is fixed */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit: I really prefer to put some kind of tracker for these kinds of TODO/FIXME changes. e.g. /* FIXME b/360833010: Restore to OBJ_COLL_THD_MIN when leak fixed */

Even better, use a new bug that can be closed when the FIXME is reverted. We do that a lot in the control plane code. Makes it harder to forget when there's an open ticket that gets looked at during planning.

@jolivier23 jolivier23 merged commit a2819ec into google/2.6 Aug 21, 2024
49 checks passed
@jolivier23 jolivier23 deleted the jvolivie/disable_collective branch August 21, 2024 14:08
jolivier23 added a commit that referenced this pull request Oct 29, 2024
jolivier23 added a commit that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants