Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16229 test: support dynamic stonewall file (#14771) #14921

Merged
merged 1 commit into from
Aug 21, 2024
Merged

DAOS-16229 test: support dynamic stonewall file (#14771) #14921

merged 1 commit into from
Aug 21, 2024

Conversation

daltonbohning
Copy link
Contributor

support dynamic stonewall file for ior and mdtest by using DAOS_TEST_LOG_DIR

Features: ior mdtest
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Aug 13, 2024
@daltonbohning daltonbohning added the unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. label Aug 13, 2024
daltonbohning
daltonbohning commented Aug 13, 2024
View reviewed changes
src/tests/ftest/deployment/agent_failure.py
@@ -31,7 +31,7 @@ def run_ior_collect_error(self, results, job_num, file_name, clients):
file_name (str): File name used for self.ior_cmd.test_file.
clients (list): Client hostnames to run IOR from.
"""
ior_cmd = IorCommand()
ior_cmd = IorCommand(self.test_env.log_dir)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unclean here because master also has namespace=namespace argument

@github-actions GitHub Actions
Copy link

Ticket title is 'ftest: support dynamic stonewall status file for ior and mdtest'
Status is 'Awaiting backport'
Labels: 'daos_framework'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16229

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Aug 13, 2024
daltonbohning added a commit that referenced this pull request Aug 13, 2024
@daltonbohning
DAOS-16229 test: support dynamic stonewall file (#14771) #14921
a4b8c4b 
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Aug 13, 2024
@daltonbohning
DAOS-16229 test: support dynamic stonewall file (#14771) #14921
1daef60 
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning
DAOS-16229 test: support dynamic stonewall file (#14771)
21d4975 
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning force-pushed the dbohning/daos-16229-2.6 branch from 6821a2f to 21d4975 Compare August 20, 2024 16:03
@daltonbohning daltonbohning marked this pull request as ready for review August 21, 2024 15:34
@daltonbohning daltonbohning requested review from a team as code owners August 21, 2024 15:34
daltonbohning added a commit that referenced this pull request Aug 21, 2024
@daltonbohning
DAOS-16229 test: support dynamic stonewall file (#14771) #14921
969bb69 
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 21, 2024
@daltonbohning daltonbohning requested a review from a team August 21, 2024 17:40
@daltonbohning daltonbohning merged commit 195d66c into release/2.6 Aug 21, 2024
47 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-16229-2.6 branch August 21, 2024 17:40
@juszhan1 juszhan1 mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpadma2 rpadma2 rpadma2 approved these changes

@shimizukko shimizukko Awaiting requested review from shimizukko

@phender phender Awaiting requested review from phender

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daltonbohning @rpadma2