Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16229 test: support dynamic stonewall file #14771

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

daltonbohning
Copy link
Contributor

support dynamic stonewall file for ior and mdtest by using DAOS_TEST_LOG_DIR

Features: ior mdtest
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Jul 15, 2024
Copy link

Ticket title is 'ftest: support dynamic stonewall status file for ior and mdtest'
Status is 'In Progress'
Labels: 'daos_framework'
https://daosio.atlassian.net/browse/DAOS-16229

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14771/2/execution/node/799/log

@daltonbohning daltonbohning force-pushed the dbohning/daos-16229 branch 2 times, most recently from ff851aa to 1f9fad0 Compare July 16, 2024 14:34
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14771/4/execution/node/799/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14771/5/execution/node/823/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14771/5/execution/node/1019/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14771/5/execution/node/1112/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14771/6/execution/node/798/log

daltonbohning added a commit that referenced this pull request Jul 18, 2024
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Jul 18, 2024
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Jul 18, 2024
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14771/6/execution/node/1019/log

daltonbohning added a commit that referenced this pull request Jul 19, 2024
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14771/7/execution/node/823/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14771/7/execution/node/1065/log

daltonbohning added a commit that referenced this pull request Jul 23, 2024
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14771/7/execution/node/1201/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14771/8/execution/node/798/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14771/8/execution/node/1019/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14771/8/execution/node/1065/log

daltonbohning added a commit that referenced this pull request Aug 2, 2024
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Aug 7, 2024
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14771/9/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14771/9/testReport/

@daltonbohning daltonbohning marked this pull request as ready for review August 8, 2024 19:07
@daltonbohning daltonbohning requested review from a team as code owners August 8, 2024 19:07
Copy link
Contributor

@saurabhtandan saurabhtandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daltonbohning daltonbohning requested a review from a team August 9, 2024 14:01
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 9, 2024
@daltonbohning
Copy link
Contributor Author

ior_per_rank.py didn't run because the skip needed to be updated
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14771/9/artifact/Functional%20Hardware%20Medium/deployment/ior_per_rank.py/job.log

Skipping until DAOS-13078 is fixed

But the change is similar to other files so I think is safe

@phender phender merged commit 1f1aa59 into master Aug 9, 2024
46 of 49 checks passed
@phender phender deleted the dbohning/daos-16229 branch August 9, 2024 19:59
daltonbohning added a commit that referenced this pull request Aug 12, 2024
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Aug 13, 2024
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Aug 13, 2024
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Aug 13, 2024
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Aug 20, 2024
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Aug 21, 2024
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Features: ior mdtest
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Aug 21, 2024
support dynamic stonewall file for ior and mdtest by using
DAOS_TEST_LOG_DIR

Signed-off-by: Dalton Bohning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

5 participants