Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14262 cart: add ability to select traffic class for SWIM context (#14893) #14917

Merged
merged 1 commit into from
Oct 24, 2024
Merged

DAOS-14262 cart: add ability to select traffic class for SWIM context (#14893) #14917

merged 1 commit into from
Oct 24, 2024

Conversation

soumagne
Copy link
Collaborator

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

Ticket title is 'Use low-latency traffic class for SWIM'
Status is 'In Progress'
Labels: 'HPE_dep,tds'
https://daosio.atlassian.net/browse/DAOS-14262

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14917/1/execution/node/372/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14917/1/execution/node/355/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14917/1/execution/node/356/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14917/1/execution/node/282/log

@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14917/1/execution/node/494/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14917/1/execution/node/362/log

@soumagne soumagne force-pushed the soumagne/swim_tc_26 branch from 790d6d3 to 1fc2da4 Compare August 12, 2024 22:02
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14917/2/execution/node/1551/log

@soumagne soumagne force-pushed the soumagne/swim_tc_26 branch from 1fc2da4 to f1ccdd8 Compare August 16, 2024 16:54
@soumagne soumagne force-pushed the soumagne/swim_tc_26 branch from f1ccdd8 to d8d0039 Compare October 2, 2024 16:57
@soumagne
DAOS-14262 cart: add ability to select traffic class for SWIM context (…
4a05959 
…#14893)

Add SWIM_TRAFFIC_CLASS env var (default is unspec)

Required-githooks: true

Signed-off-by: Jerome Soumagne <[email protected]>
@soumagne soumagne force-pushed the soumagne/swim_tc_26 branch from d8d0039 to 4a05959 Compare October 22, 2024 20:22
@soumagne soumagne changed the title DAOS-14262 cart: use NA_TC_BULK_DATA traffic class for SWIM context DAOS-14262 cart: add ability to select traffic class for SWIM context (#14893) Oct 22, 2024
@soumagne soumagne marked this pull request as ready for review October 22, 2024 20:25
@soumagne soumagne requested review from a team as code owners October 22, 2024 20:25
@soumagne soumagne added the unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. label Oct 22, 2024
@soumagne soumagne requested a review from a team October 24, 2024 15:05
@mchaarawi mchaarawi merged commit 2b5620b into release/2.6 Oct 24, 2024
53 of 54 checks passed
@mchaarawi mchaarawi deleted the soumagne/swim_tc_26 branch October 24, 2024 15:47
@mjean308 mjean308 mentioned this pull request Oct 24, 2024
Closed
18 tasks
@juszhan1 juszhan1 mentioned this pull request Oct 28, 2024
Closed
juszhan1 added a commit that referenced this pull request Oct 28, 2024
@juszhan1
Revert "DAOS-14262 cart: add ability to select traffic class for SWIM…
ce19b89 
… context (#14893) (#14917)"

This reverts commit 2b5620b.
@juszhan1 juszhan1 mentioned this pull request Oct 28, 2024
Closed
juszhan1 added a commit that referenced this pull request Oct 28, 2024
@juszhan1
Revert "DAOS-14262 cart: add ability to select traffic class for SWIM…
7941cb7 
… context (#14893) (#14917)"

This reverts commit 2b5620b.
@juszhan1 juszhan1 mentioned this pull request Oct 28, 2024
Closed
@mjmac mjmac mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostedcmos frostedcmos frostedcmos approved these changes

@jgmoore-or jgmoore-or Awaiting requested review from jgmoore-or

Assignees
No one assigned
Labels
unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soumagne @daosbuild1 @frostedcmos @mchaarawi