Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14262 cart: add ability to select traffic class for SWIM context #14893

Merged
merged 5 commits into from
Oct 22, 2024
Merged

DAOS-14262 cart: add ability to select traffic class for SWIM context #14893

merged 5 commits into from
Oct 22, 2024

Conversation

soumagne
Copy link
Collaborator

@soumagne soumagne commented Aug 7, 2024

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@soumagne soumagne requested a review from frostedcmos August 7, 2024 21:26
@soumagne
Copy link
Collaborator Author

soumagne commented Aug 7, 2024

Will rebase PR once #14662 has landed

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Ticket title is 'Use low-latency traffic class for SWIM'
Status is 'In Progress'
Labels: 'HPE_dep,tds'
https://daosio.atlassian.net/browse/DAOS-14262

frostedcmos
frostedcmos reviewed Aug 7, 2024
View reviewed changes
src/cart/crt_hg.c Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14893/1/execution/node/1416/log

@soumagne soumagne requested a review from frostedcmos August 12, 2024 19:50
@soumagne soumagne marked this pull request as ready for review August 12, 2024 19:50
@soumagne soumagne requested review from a team as code owners August 12, 2024 19:50
@soumagne soumagne requested a review from jgmoore-or August 12, 2024 19:50
frostedcmos
frostedcmos previously approved these changes Aug 12, 2024
View reviewed changes
@soumagne
DAOS-14262 cart: add ability to select SWIM traffic class
fa1ebc2 
Add SWIM_TRAFFIC_CLASS env var (default is unspec)

Required-githooks: true

Signed-off-by: Jerome Soumagne <[email protected]>
@soumagne soumagne changed the title DAOS-14262 cart: use NA_TC_BULK_DATA traffic class for SWIM context DAOS-14262 cart: add ability to select traffic class for SWIM context Sep 30, 2024
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14893/3/execution/node/1430/log

@soumagne
DAOS-14262 cart: update README.env
40a2ebe 
Required-githooks: true

Signed-off-by: Jerome Soumagne <[email protected]>
daltonbohning
daltonbohning reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far seems to be working as expected on aurora, using SWIM_TRAFFIC_CLASS=low_latency

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14893/5/execution/node/1544/log

@soumagne soumagne requested a review from a team October 14, 2024 21:21
@soumagne soumagne added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Oct 14, 2024
@soumagne
Copy link
Collaborator Author

soumagne commented Oct 14, 2024 •
edited
Loading

memory alloc issue in hardware medium unrelated to PR

@mchaarawi
Copy link
Contributor

memory alloc issue in hardware medium unrelated to PR

the issue is already fixed in latest master. please rebase.
the change do affect the tests that have failed, so we can't force land this.

@mchaarawi mchaarawi removed the request for review from a team October 14, 2024 22:05
@soumagne soumagne removed the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Oct 22, 2024
@soumagne soumagne requested a review from a team October 22, 2024 14:29
@mchaarawi mchaarawi merged commit 63305f3 into master Oct 22, 2024
53 of 54 checks passed
@mchaarawi mchaarawi deleted the soumagne/swim_tc branch October 22, 2024 18:52
soumagne added a commit that referenced this pull request Oct 22, 2024
@soumagne
DAOS-14262 cart: add ability to select traffic class for SWIM context (…
4a05959 
…#14893)

Add SWIM_TRAFFIC_CLASS env var (default is unspec)

Required-githooks: true

Signed-off-by: Jerome Soumagne <[email protected]>
daltonbohning pushed a commit that referenced this pull request Oct 23, 2024
@soumagne @daltonbohning
DAOS-14262 cart: add ability to select traffic class for SWIM context (…
8fd150e 
…#14893)

Add SWIM_TRAFFIC_CLASS env var (default is unspec)

Required-githooks: true

Signed-off-by: Jerome Soumagne <[email protected]>
daltonbohning pushed a commit that referenced this pull request Oct 24, 2024
@soumagne @daltonbohning
DAOS-14262 cart: add ability to select traffic class for SWIM context (…
ac4fc43 
…#14893)

Add SWIM_TRAFFIC_CLASS env var (default is unspec)

Required-githooks: true

Signed-off-by: Jerome Soumagne <[email protected]>
mchaarawi pushed a commit that referenced this pull request Oct 24, 2024
@soumagne
DAOS-14262 cart: add ability to select traffic class for SWIM context (…
2b5620b 
…#14893) (#14917)

Add SWIM_TRAFFIC_CLASS env var (default is unspec)

Signed-off-by: Jerome Soumagne <[email protected]>
@juszhan1 juszhan1 mentioned this pull request Oct 28, 2024
Closed
juszhan1 added a commit that referenced this pull request Oct 28, 2024
@juszhan1
Revert "DAOS-14262 cart: add ability to select traffic class for SWIM…
ce19b89 
… context (#14893) (#14917)"

This reverts commit 2b5620b.
@juszhan1 juszhan1 mentioned this pull request Oct 28, 2024
Closed
juszhan1 added a commit that referenced this pull request Oct 28, 2024
@juszhan1
Revert "DAOS-14262 cart: add ability to select traffic class for SWIM…
7941cb7 
… context (#14893) (#14917)"

This reverts commit 2b5620b.
@juszhan1 juszhan1 mentioned this pull request Oct 28, 2024
Closed
This was referenced Nov 6, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning left review comments

@frostedcmos frostedcmos frostedcmos approved these changes

@jgmoore-or jgmoore-or jgmoore-or approved these changes

@mchaarawi mchaarawi Awaiting requested review from mchaarawi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@soumagne @daosbuild1 @mchaarawi @daltonbohning @jgmoore-or @frostedcmos