Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15931 rebuild: fix data corruption caused by partial parity rebu… #14519

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

jolivier23
Copy link
Contributor

…ild epoch (#14512)

Rebuild code change:

  1. __migrate_fetch_update_parity(), fix a bug when set partial replica rebuild epoch for parity shard rebuild.
  2. __migrate_fetch_update_bulk() should carry DIOF_FOR_MIGRATION flag,
  3. migrate_fetch_update_parity() parameter fix when calling __migrate_fetch_update_parity().

EC aggregation change:

  1. ds_obj_ec_rep_handler() and ds_obj_ec_agg_handler(), the vos_update_begin() should carry VOS_OF_REBUILD to avoid -DER_VOS_PARTIAL_UPDATE failure.
  2. give more chance to abort EC agg when rebuild started, to save conflict window.

includes backports of
DAOS-15007 object: fix EC aggregation's ap_min_unagg_eph set (#13875) DAOS-15262 vos: Fix probe issue in vos iterator (#13918) DAOS-14908 vos: Reduce aggregation conflicts (#14143)

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

…ild epoch

Rebuild code change:
1. __migrate_fetch_update_parity(), fix a bug when set partial replica
   rebuild epoch for parity shard rebuild.
2. __migrate_fetch_update_bulk() should carry DIOF_FOR_MIGRATION flag,
3. migrate_fetch_update_parity() parameter fix when calling
   __migrate_fetch_update_parity().

EC aggregation change:
1. ds_obj_ec_rep_handler() and ds_obj_ec_agg_handler(), the vos_update_begin()
   should carry VOS_OF_REBUILD to avoid -DER_VOS_PARTIAL_UPDATE failure.
2. give more chance to abort EC agg when rebuild started, to save
   conflict window.

includes backports of
DAOS-15007 object: fix EC aggregation's ap_min_unagg_eph set (#13875)
DAOS-15262 vos: Fix probe issue in vos iterator (#13918)
DAOS-14908 vos: Reduce aggregation conflicts (#14143)

Signed-off-by: Jeff Olivier <[email protected]>
Signed-off-by: Xuezhao Liu <[email protected]>
Signed-off-by: Niu Yawei <[email protected]>
Copy link

github-actions bot commented Jun 5, 2024

Bug-tracker data:
Ticket title is 'data corruptions found if reintegration triggered while pool rebuild is running'
Status is 'In Review'
Labels: 'google-cloud-daos,scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-15931

Comment on lines +1556 to +1557
mrone, oh, &iod, 1, fetch_eph, update_eph,
DIOF_EC_RECOV_FROM_PARITY | DIOF_FOR_MIGRATION, ds_cont);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mrone, oh, &iod, 1, fetch_eph, update_eph,
DIOF_EC_RECOV_FROM_PARITY | DIOF_FOR_MIGRATION, ds_cont);
mrone, oh, &iod, 1, fetch_eph, update_eph,
DIOF_EC_RECOV_FROM_PARITY | DIOF_FOR_MIGRATION, ds_cont);

#define VOS_TX_LOG_FAIL(rc, ...) \
do { \
bool __is_err = true; \
\
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
\
\

#define VOS_TX_TRACE_FAIL(rc, ...) \
do { \
bool __is_err = true; \
\
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
\
\

@daosbuild1
Copy link
Collaborator

@jolivier23 jolivier23 merged commit c9b6084 into google/2.4 Jun 6, 2024
32 of 34 checks passed
@jolivier23 jolivier23 deleted the jvolivie/lxzpatch branch June 6, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants