Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15007 object: fix EC aggregation's ap_min_unagg_eph set #13875

Merged
merged 2 commits into from
Mar 1, 2024
Merged

DAOS-15007 object: fix EC aggregation's ap_min_unagg_eph set #13875

merged 2 commits into from
Mar 1, 2024

Conversation

liuxuezhao
Copy link
Contributor

Should init it before any case goto update_hae, or will cause epoch boundary cannot move ahead.

Required-githooks: true
Test-tag: test_ec_offline_rebuild_fio test_ec_online_rebuild_fio pr

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@liuxuezhao liuxuezhao requested review from a team as code owners February 26, 2024 08:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2024 •
edited
Loading

Ticket title is 'erasurecode/rebuild_fio.py:EcodFioRebuild.test_ec_offline_rebuild_fio - Aggregation not observed within 180 seconds'
Status is 'In Progress'
Labels: 'ci_impact,scrubbed,triaged,weekly_test'
https://daosio.atlassian.net/browse/DAOS-15007

@liuxuezhao liuxuezhao removed request for a team February 26, 2024 09:57
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13875/1/execution/node/1497/log

@liuxuezhao liuxuezhao force-pushed the lxz/ap_min_unagg_eph_fix branch from e57b8a4 to df0649c Compare February 28, 2024 02:56
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13875/2/execution/node/1173/log

@liuxuezhao
DAOS-15007 object: fix EC aggregation's ap_min_unagg_eph set
a0cf510 
Should init it before any case goto update_hae, or will cause
epoch boundary cannot move ahead.

Required-githooks: true

Signed-off-by: Xuezhao Liu <[email protected]>
@liuxuezhao liuxuezhao force-pushed the lxz/ap_min_unagg_eph_fix branch from df0649c to a0cf510 Compare February 28, 2024 08:30
@liuxuezhao liuxuezhao closed this Feb 29, 2024
@liuxuezhao liuxuezhao reopened this Feb 29, 2024
@daos-stack daos-stack deleted a comment from wangdi1 Feb 29, 2024
@liuxuezhao liuxuezhao requested a review from a team March 1, 2024 01:04
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Mar 1, 2024
@daltonbohning daltonbohning merged commit 2a43614 into master Mar 1, 2024
47 of 49 checks passed
@daltonbohning daltonbohning deleted the lxz/ap_min_unagg_eph_fix branch March 1, 2024 16:19
jolivier23 pushed a commit that referenced this pull request Jun 5, 2024
@liuxuezhao @jolivier23
DAOS-15931 rebuild: fix data corruption caused by partial parity rebu…
8c80601 
…ild epoch

Rebuild code change:
1. __migrate_fetch_update_parity(), fix a bug when set partial replica
   rebuild epoch for parity shard rebuild.
2. __migrate_fetch_update_bulk() should carry DIOF_FOR_MIGRATION flag,
3. migrate_fetch_update_parity() parameter fix when calling
   __migrate_fetch_update_parity().

EC aggregation change:
1. ds_obj_ec_rep_handler() and ds_obj_ec_agg_handler(), the vos_update_begin()
   should carry VOS_OF_REBUILD to avoid -DER_VOS_PARTIAL_UPDATE failure.
2. give more chance to abort EC agg when rebuild started, to save
   conflict window.

includes backports of
DAOS-15007 object: fix EC aggregation's ap_min_unagg_eph set (#13875)
DAOS-15262 vos: Fix probe issue in vos iterator (#13918)
DAOS-14908 vos: Reduce aggregation conflicts (#14143)

Signed-off-by: Jeff Olivier <[email protected]>
Signed-off-by: Xuezhao Liu <[email protected]>
Signed-off-by: Niu Yawei <[email protected]>
@jolivier23 jolivier23 mentioned this pull request Jun 5, 2024
Merged
18 tasks
jolivier23 added a commit that referenced this pull request Jun 6, 2024
@jolivier23
DAOS-15931 rebuild: fix data corruption caused by partial parity rebu…
c9b6084 
…ild epoch (#14519)

Rebuild code change:
1. __migrate_fetch_update_parity(), fix a bug when set partial replica
   rebuild epoch for parity shard rebuild.
2. __migrate_fetch_update_bulk() should carry DIOF_FOR_MIGRATION flag,
3. migrate_fetch_update_parity() parameter fix when calling
   __migrate_fetch_update_parity().

EC aggregation change:
1. ds_obj_ec_rep_handler() and ds_obj_ec_agg_handler(), the vos_update_begin()
   should carry VOS_OF_REBUILD to avoid -DER_VOS_PARTIAL_UPDATE failure.
2. give more chance to abort EC agg when rebuild started, to save
   conflict window.

includes backports of
DAOS-15007 object: fix EC aggregation's ap_min_unagg_eph set (#13875)
DAOS-15262 vos: Fix probe issue in vos iterator (#13918)
DAOS-14908 vos: Reduce aggregation conflicts (#14143)

Signed-off-by: Jeff Olivier <[email protected]>
Signed-off-by: Xuezhao Liu <[email protected]>
Signed-off-by: Niu Yawei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangdi1 wangdi1 wangdi1 approved these changes

@NiuYawei NiuYawei NiuYawei approved these changes

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liuxuezhao @daosbuild1 @NiuYawei @wangdi1 @daltonbohning