Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-14831 test: use scm and nvme for ior/hard_rebuild (#13551) #13652

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

daltonbohning
Copy link
Contributor

Test-tag: EcodIorHardRebuild
Test-repeat: 3
Skip-func-test-hw-large-md-on-ssd: False
Skip-unit-tests: true
Skip-fault-injection-test: true

  • Use both SCM and NVMe when creating a pool to accomodate MD on SSD.
  • Use GX so space is spread across targets.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Test-tag: EcodIorHardRebuild
Test-repeat: 3
Skip-func-test-hw-large-md-on-ssd: False
Skip-unit-tests: true
Skip-fault-injection-test: true

- Use both SCM and NVMe when creating a pool to accomodate MD on SSD.
- Use GX so space is spread across targets.

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning self-assigned this Jan 23, 2024
Copy link

Bug-tracker data:
Ticket title is 'ior/hard_rebuild.py:EcodIorHardRebuild.test_ec_ior_hard_online_rebuild - ior no space left on device after system stop'
Status is 'Awaiting backport'
Labels: 'ci_impact,md_on_ssd,triaged,weekly_test'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-14831

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jan 23, 2024
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daltonbohning daltonbohning marked this pull request as ready for review January 24, 2024 16:56
@daltonbohning daltonbohning requested a review from a team as a code owner January 24, 2024 16:56
@daltonbohning daltonbohning added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jan 24, 2024
@daltonbohning
Copy link
Contributor Author

@daltonbohning daltonbohning requested a review from phender January 25, 2024 20:57
@phender phender merged commit be9f5d6 into release/2.4 Jan 25, 2024
28 checks passed
@phender phender deleted the dbohning/daos-14831 branch January 25, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed)
Development

Successfully merging this pull request may close these issues.

3 participants