Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14831 test: use scm and nvme for ior/hard_rebuild #13551

Merged
merged 1 commit into from
Jan 18, 2024
Merged

DAOS-14831 test: use scm and nvme for ior/hard_rebuild #13551

merged 1 commit into from
Jan 18, 2024

Conversation

daltonbohning
Copy link
Contributor

@daltonbohning daltonbohning commented Jan 2, 2024 •
edited
Loading

Test-tag: EcodIorHardRebuild
Test-repeat: 3
Skip-func-test-hw-large-md-on-ssd: False
Skip-unit-tests: true
Skip-fault-injection-test: true

  • Use both SCM and NVMe when creating a pool to accomodate MD on SSD.
  • Use GX so space is spread across targets.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Jan 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024

Bug-tracker data:
Ticket title is 'ior/hard_rebuild.py:EcodIorHardRebuild.test_ec_ior_hard_online_rebuild - ior no space left on device after system stop'
Status is 'In Progress'
Labels: 'ci_impact,md_on_ssd,triaged,weekly_test'
https://daosio.atlassian.net/browse/DAOS-14831

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13551/1/execution/node/833/log

@daltonbohning daltonbohning changed the title DAOS-14831 test: reduce ior/hard_rebuild stonewall DAOS-14831 test: use scm and nvme for ior/hard_rebuild Jan 2, 2024
@daltonbohning daltonbohning mentioned this pull request Jan 2, 2024
Merged
18 tasks
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13551/2/execution/node/810/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13551/2/execution/node/856/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large MD on SSD completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13551/3/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13551/3/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13551/4/execution/node/810/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13551/4/execution/node/907/log

@daltonbohning
DAOS-14831 test: use scm and nvme for ior/hard_rebuild
fc24993 
Test-tag: EcodIorHardRebuild
Test-repeat: 3
Skip-func-test-hw-large-md-on-ssd: False
Skip-unit-tests: true
Skip-fault-injection-test: true

- Use both SCM and NVMe when creating a pool to accomodate MD on SSD.
- Use GX so space is spread across targets.

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning
Copy link
Contributor Author

Test passed with nvme and md on ssd 3 times each:
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13551/5/testReport/FTEST_ior/EcodIorHardRebuild/

@daltonbohning daltonbohning marked this pull request as ready for review January 9, 2024 22:07
@daltonbohning daltonbohning requested a review from a team as a code owner January 9, 2024 22:07
@daltonbohning
Copy link
Contributor Author

Ping reviewers

@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 16, 2024
@daltonbohning daltonbohning requested a review from a team January 16, 2024 22:34
@phender phender merged commit cf10b98 into master Jan 18, 2024
41 checks passed
@phender phender deleted the dbohning/daos-14831 branch January 18, 2024 20:24
daltonbohning added a commit that referenced this pull request Jan 23, 2024
@daltonbohning
DAOS-14831 test: use scm and nvme for ior/hard_rebuild (#13551)
8b09543 
Test-tag: EcodIorHardRebuild
Test-repeat: 3
Skip-func-test-hw-large-md-on-ssd: False
Skip-unit-tests: true
Skip-fault-injection-test: true

- Use both SCM and NVMe when creating a pool to accomodate MD on SSD.
- Use GX so space is spread across targets.

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
phender pushed a commit that referenced this pull request Jan 25, 2024
@daltonbohning
DAOS-14831 test: use scm and nvme for ior/hard_rebuild (#13551) (#13652)
be9f5d6 
- Use both SCM and NVMe when creating a pool to accommodate MD on SSD.
- Use GX so space is spread across targets.

Signed-off-by: Dalton Bohning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpadma2 rpadma2 rpadma2 approved these changes

@shimizukko shimizukko shimizukko approved these changes

@dinghwah dinghwah Awaiting requested review from dinghwah

@phender phender Awaiting requested review from phender

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daltonbohning @daosbuild1 @shimizukko @rpadma2 @phender