DAOS-13510 chk: Query output should include dry-run status #12294
Conversation
|
Bug-tracker data: |
|
@Nasf-Fan: Please take a look to see if this is what you had in mind. The only issue that I can see is that there does not appear to be a way to get out of dry-run mode. If I run I think probably we need to clear the property flag if the user did not specify it with the start command. I tried to implement that, but ran into some trouble. Perhaps you can suggest a solution that I can include with this patch, thanks. |
If the checker is running in dry-run mode, notify the user. Required-githooks: true Signed-off-by: Michael MacDonald <[email protected]>
There was a problem hiding this comment.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12294/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
src/chk/chk_leader.c
Outdated
| cru->cru_detail_nr, cru->cru_details); | ||
| dryrun = ins->ci_prop.cp_flags & CHK__CHECK_FLAG__CF_DRYRUN; | ||
| rc = chk_report_upcall(cru->cru_gen, *seq, cru->cru_cla, cru->cru_act, cru->cru_result, | ||
| cru->cru_rank, cru->cru_target, cru->cru_pool, cru->cru_pool_label, |
There was a problem hiding this comment.
(style) line over 100 characters
src/chk/chk_leader.c
Outdated
| rc = chk_report_upcall(cru->cru_gen, *seq, cru->cru_cla, cru->cru_act, cru->cru_result, | ||
| cru->cru_rank, cru->cru_target, cru->cru_pool, cru->cru_pool_label, | ||
| cru->cru_cont, cru->cru_cont_label, cru->cru_obj, cru->cru_dkey, | ||
| cru->cru_akey, cru->cru_msg, cru->cru_option_nr, cru->cru_options, |
There was a problem hiding this comment.
(style) line over 100 characters
|
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12294/2/execution/node/146/log |
|
Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12294/2/execution/node/1237/log |
|
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12294/2/execution/node/1284/log |
Does MS store the "dryrun" flag somewhere? If not, then when you start checker next time without "--dry-run", then the former "dryrun" will be automatically removed. If it does not work, then it is daos engine bug, and I need to fix it. Would you please to verify the "dryrun" behavior against the patch #12242 ? In such patch, we start checker with "dryrun" firstly, and then without "dryrun" in subsequent "check start". According to the CI test result, it works. |
|
As my understand, MS can have more simple way to know whether current check instance is running under "dryrun" mode or not. For example, when user input "dmg check query", then MS can handle that in two steps:
With the firstly step checker property information, you can know whether current checker is running under dryrun mode or not. That will much simplify the patch. How do you think? |
Features: recovery control Required-githooks: true
There was a problem hiding this comment.
@kjacque, as my understand, MS can have more simple way to know whether current check instance is running under "dryrun" mode instead of changing the API just for the dryrun flag. For example, when user input "dmg check query", then MS can handle that in two steps:
Firstly, trigger DRPC_METHOD_MGMT_CHK_PROP to DAOS engine, then it will get current checker start options, that includes the "dryrun" flag if have.
Then, trigger DRPC_METHOD_MGMT_CHK_QUERY to DAOS engine as you orignal "dmg check query" does.
With the firstly step checker property information, you can know whether current checker is running under dryrun mode or not. That will much simplify current patch.
If the checker is running in dry-run mode, notify the user.
Required-githooks: true
Signed-off-by: Michael MacDonald [email protected]