DAOS-13047 chk: properly handle start options #12242

Nasf-Fan · 2023-05-31T03:45:15Z

Test-tag-hw-medium: Pass1Test

The start options for new instance should properly overwrite old ones. It also enhances CR pass 1 functionality tests:

Verify DAOS checker under dryrun mode.
Verify DAOS checker under auto mode.
Verify that the DAOS checker can detect and repair the inconsistency under regular mode.
Fix some typo for the test tags.
More accurate comment for test flow.

Before requesting gatekeeper:

Two review approvals and any prior change requests have been resolved.
Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
Commit messages follows the guidelines outlined here.
Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

Test-tag-hw-medium: Pass1Test The start options for new instance should properly overwrite old ones. It also enhances CR pass 1 functionality tests: 1. Verify DAOS checker under dryrun mode. 2. Verify DAOS checker under auto mode. 3. Verify that the DAOS checker can detect and repair the inconsistency under regular mode. 4. Fix some typo for the test tags. 5. More accurate comment for test flow. Signed-off-by: Fan Yong <[email protected]>

Remove blank line. Signed-off-by: Fan Yong <[email protected]>

github-actions · 2023-05-31T03:45:38Z

Bug-tracker data:
Ticket title is 'CR unit test for DAOS distributed check engine logic'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-13047

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-05-31T07:51:46Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12242/3/execution/node/1209/log

daosbuild1 · 2023-05-31T11:18:28Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12242/3/execution/node/1162/log

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-05-31T21:49:10Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12242/4/execution/node/1212/log

src/tests/ftest/recovery/pass_1.py

src/tests/ftest/util/dmg_utils.py

shimizukko

You should change the method name test_run_checker() to not start with test_ because it's the helper method.

shimizukko · 2023-06-05T23:35:14Z

src/tests/ftest/recovery/pass_1.py

+                break
+            time.sleep(5)
+
+        # 6.3 Verify that the checker detected the dangling pool.


Suggested change

# 6.3 Verify that the checker detected the dangling pool.

# 6.3 Verify that the checker detected the inconsistency.

shimizukko · 2023-06-05T23:35:41Z

src/tests/ftest/recovery/pass_1.py

+        dmg_command.check_set_policy(reset_defaults=True)
+
+        # 6.1 Start check with auto=off,
+        # that will find the dangling pool and remove it.


Suggested change

# that will find the dangling pool and remove it.

# that will find the inconsistency and fix it.

src/tests/ftest/recovery/pass_1.py

shimizukko · 2023-06-05T23:44:36Z

src/tests/ftest/recovery/pass_1.py

+        1. Enable check mode.
+        2. Run checker under dry-run mode.
+        3. Set repair policy as interaction.
+        4. Run checker under auto mode.


Suggested change

4. Run checker under auto mode.

4. Run checker under auto mode and verify that it detects inconsistency.

shimizukko · 2023-06-05T23:52:35Z

src/tests/ftest/recovery/pass_1.py

@@ -187,32 +220,20 @@ def test_orphan_pool_trus_ps(self):
        :avocado: tags=Pass1Test,test_orphan_pool_trust_ps
        """
        errors = []
-        # Run step 1 to 6.
+        # 4. Run DAOS checker under kinds of mode.


Not sure if it's a good idea to remove steps from the method description. I know it's duplicate of what you wrote in run_checker_on_orphan_pool(), but it would make it harder to understand what this test does. If you really want to remove it, then you might want to improve the comment here. e.g.,

Suggested change

# 4. Run DAOS checker under kinds of mode.

# 1-4. Create a pool, remove the PS entry, list and verify that there's no pool, run and verify the checker behavior.

The steps are moved to run_checker, not removed.

shimizukko · 2023-06-05T23:54:07Z

src/tests/ftest/recovery/pass_1.py

        errors = self.run_checker_on_orphan_pool(
            policies="POOL_NONEXIST_ON_MS:CIA_TRUST_MS")

-        # 7. Verify that the orphan pool was removed.
+        # Verify that the orphan pool was destroyed.


Not sure if it's a good idea to remove the test steps from the method description.

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-06-06T18:40:16Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12242/7/execution/node/1237/log

daltonbohning · 2023-06-07T15:32:07Z

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-13047_options branch from c19d9d9 to 24a71b8
yesterday

FYI - it's better to not force push after review so reviewers can see the diff

daltonbohning

ftest LGTM

daltonbohning · 2023-06-07T15:34:04Z

src/tests/ftest/util/dmg_utils.py

+        """
+


Suggested change

"""

"""

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-06-08T17:34:48Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12242/8/execution/node/1267/log

Nasf-Fan · 2023-06-12T04:31:41Z

@mjmac @daltonbohning , would you please to help review the patch again? Thanks!

Nasf-Fan added 2 commits May 30, 2023 15:53

DAOS-13047 tests: refresh CR test comment

63f26fd

Remove blank line. Signed-off-by: Fan Yong <[email protected]>

daosbuild1 reviewed May 31, 2023

View reviewed changes

Nasf-Fan force-pushed the Nasf-Fan/DAOS-13047_options branch from e0d5a68 to bc4c64a Compare May 31, 2023 04:00

daosbuild1 reviewed May 31, 2023

View reviewed changes

Nasf-Fan force-pushed the Nasf-Fan/DAOS-13047_options branch from bc4c64a to da1e1e1 Compare May 31, 2023 04:07

daosbuild1 reviewed May 31, 2023

View reviewed changes

Nasf-Fan force-pushed the Nasf-Fan/DAOS-13047_options branch from da1e1e1 to ce96c87 Compare May 31, 2023 13:08

daosbuild1 reviewed May 31, 2023

View reviewed changes

Nasf-Fan marked this pull request as ready for review June 4, 2023 10:07

Nasf-Fan requested a review from a team as a code owner June 4, 2023 10:07

Nasf-Fan requested review from mjmac and shimizukko June 5, 2023 06:49

daltonbohning reviewed Jun 5, 2023

View reviewed changes

src/tests/ftest/recovery/pass_1.py Outdated Show resolved Hide resolved

src/tests/ftest/recovery/pass_1.py Outdated Show resolved Hide resolved

src/tests/ftest/util/dmg_utils.py Outdated Show resolved Hide resolved

shimizukko approved these changes Jun 5, 2023

View reviewed changes

Nasf-Fan force-pushed the Nasf-Fan/DAOS-13047_options branch from ce96c87 to 79b2322 Compare June 6, 2023 10:23

daosbuild1 reviewed Jun 6, 2023

View reviewed changes

Nasf-Fan force-pushed the Nasf-Fan/DAOS-13047_options branch from 79b2322 to c19d9d9 Compare June 6, 2023 10:40

daosbuild1 reviewed Jun 6, 2023

View reviewed changes

Nasf-Fan force-pushed the Nasf-Fan/DAOS-13047_options branch from c19d9d9 to 24a71b8 Compare June 6, 2023 11:03

daosbuild1 reviewed Jun 6, 2023

View reviewed changes

Nasf-Fan requested a review from daltonbohning June 7, 2023 01:26

daltonbohning reviewed Jun 7, 2023

View reviewed changes

src/tests/ftest/util/dmg_utils.py Outdated

Comment on lines 1365 to 1366

"""

Copy link

Contributor

daltonbohning Jun 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

"""

"""

Nasf-Fan requested a review from daltonbohning June 8, 2023 00:21

daosbuild1 reviewed Jun 8, 2023

View reviewed changes

Nasf-Fan mentioned this pull request Jun 9, 2023

DAOS-13510 chk: Query output should include dry-run status #12294

Closed

Nasf-Fan added the CR Catastrophic Recovery Feature label Jun 10, 2023

mjmac approved these changes Jun 12, 2023

View reviewed changes

mjmac merged commit 06ebead into feature/cat_recovery Jun 12, 2023

mjmac deleted the Nasf-Fan/DAOS-13047_options branch June 12, 2023 13:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAOS-13047 chk: properly handle start options #12242

DAOS-13047 chk: properly handle start options #12242

Nasf-Fan commented May 31, 2023

github-actions bot commented May 31, 2023

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 commented May 31, 2023

daosbuild1 commented May 31, 2023

daosbuild1 left a comment

daosbuild1 commented May 31, 2023

shimizukko left a comment

shimizukko Jun 5, 2023

shimizukko Jun 5, 2023

shimizukko Jun 5, 2023

shimizukko Jun 5, 2023

Nasf-Fan Jun 6, 2023

shimizukko Jun 5, 2023

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 commented Jun 6, 2023

daltonbohning commented Jun 7, 2023

daltonbohning left a comment

daltonbohning Jun 7, 2023

daosbuild1 left a comment

daosbuild1 commented Jun 8, 2023

Nasf-Fan commented Jun 12, 2023

	# 6.3 Verify that the checker detected the dangling pool.
	# 6.3 Verify that the checker detected the inconsistency.

	# that will find the dangling pool and remove it.
	# that will find the inconsistency and fix it.

	4. Run checker under auto mode.
	4. Run checker under auto mode and verify that it detects inconsistency.

	# 4. Run DAOS checker under kinds of mode.
	# 1-4. Create a pool, remove the PS entry, list and verify that there's no pool, run and verify the checker behavior.

DAOS-13047 chk: properly handle start options #12242

DAOS-13047 chk: properly handle start options #12242

Conversation

Nasf-Fan commented May 31, 2023

Before requesting gatekeeper:

Gatekeeper:

github-actions bot commented May 31, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented May 31, 2023

daosbuild1 commented May 31, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented May 31, 2023

shimizukko left a comment

Choose a reason for hiding this comment

shimizukko Jun 5, 2023

Choose a reason for hiding this comment

shimizukko Jun 5, 2023

Choose a reason for hiding this comment

shimizukko Jun 5, 2023

Choose a reason for hiding this comment

shimizukko Jun 5, 2023

Choose a reason for hiding this comment

Nasf-Fan Jun 6, 2023

Choose a reason for hiding this comment

shimizukko Jun 5, 2023

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Jun 6, 2023

daltonbohning commented Jun 7, 2023

daltonbohning left a comment

Choose a reason for hiding this comment

daltonbohning Jun 7, 2023

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Jun 8, 2023

Nasf-Fan commented Jun 12, 2023