Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-12158 test: daos_test/suite.py /var/tmp/daos_testing/*log* files exceeded the 2G threshold #10960

Merged
merged 2 commits into from
Dec 8, 2022
Merged

DAOS-12158 test: daos_test/suite.py /var/tmp/daos_testing/*log* files exceeded the 2G threshold #10960

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70f0087
Update launch.py DEFAULT_LOGS_THRESHOLD = "2.1G"
dinghwah Dec 1, 2022
1023602
Update with 2150M
dinghwah Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tests/ftest/launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
DEFAULT_DAOS_TEST_LOG_DIR = os.path.join(os.sep, "var", "tmp", "daos_testing")
DEFAULT_DAOS_TEST_USER_DIR = os.path.join(os.sep, "var", "tmp", "daos_testing", "user")
DEFAULT_DAOS_TEST_SHARED_DIR = os.path.expanduser(os.path.join("~", "daos_test"))
DEFAULT_LOGS_THRESHOLD = "2G"
DEFAULT_LOGS_THRESHOLD = "2.1G"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phender I see this was your recommendation in the ticket, but isn't this just a moving target? Won't we end up hitting the threshold again if log sizes increase?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem in the ticket is the rotated server log (DAOS_Management_daos_server_1.log.83131.old) is just a bit larger than the 2G threshold. There is a race condition where this can happen and rather than complicate the log rotation code to ensure we never exceed the rotation size, it was deemed simpler to add a little wiggle room in the log threshold check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK we have only seen this in release/2.2 so far - at least in terms of daily runs - so to confirm this is working we may need to repeat running the daos_test/suite.py test or run this in the release/2.2 branch. In either case a detailed examination of the artifact/Functional%20Hardware%20Medium/launch/functional_hardware_medium/*-daos_test-suite-launch.log will be required.

FAILURE_TRIGGER = "00_trigger-launch-failure_00"
LOG_FILE_FORMAT = "%(asctime)s %(levelname)-5s %(funcName)30s: %(message)s"
PROVIDER_KEYS = OrderedDict(
Expand Down