Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-12158 test: daos_test/suite.py /var/tmp/daos_testing/*log* files exceeded the 2G threshold #10960

Merged
merged 2 commits into from
Dec 8, 2022
Merged

DAOS-12158 test: daos_test/suite.py /var/tmp/daos_testing/*log* files exceeded the 2G threshold #10960

merged 2 commits into from
Dec 8, 2022

Conversation

dinghwah
Copy link
Contributor

@dinghwah dinghwah commented Dec 1, 2022

Update launch.py DEFAULT_LOGS_THRESHOLD to "2.1G"
Skip-unit-tests: true
Allow-unstable-test: true
Doc-only: false
Test-tag: daos_test
Required-githooks: true
Signed-off-by: Ding Ho [email protected]

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@dinghwah
Update launch.py DEFAULT_LOGS_THRESHOLD = "2.1G"
70f0087 
Skip-unit-tests: true
Allow-unstable-test: true
Doc-only: false
Test-tag: daos_test
Required-githooks: true
Signed-off-by: Ding Ho [email protected]
@dinghwah dinghwah requested a review from a team as a code owner December 1, 2022 20:44
daosbuild1
daosbuild1 reviewed Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daltonbohning
daltonbohning previously approved these changes Dec 1, 2022
View reviewed changes
src/tests/ftest/launch.py Outdated
@@ -47,7 +47,7 @@
DEFAULT_DAOS_TEST_LOG_DIR = os.path.join(os.sep, "var", "tmp", "daos_testing")
DEFAULT_DAOS_TEST_USER_DIR = os.path.join(os.sep, "var", "tmp", "daos_testing", "user")
DEFAULT_DAOS_TEST_SHARED_DIR = os.path.expanduser(os.path.join("~", "daos_test"))
DEFAULT_LOGS_THRESHOLD = "2G"
DEFAULT_LOGS_THRESHOLD = "2.1G"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phender I see this was your recommendation in the ticket, but isn't this just a moving target? Won't we end up hitting the threshold again if log sizes increase?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem in the ticket is the rotated server log (DAOS_Management_daos_server_1.log.83131.old) is just a bit larger than the 2G threshold. There is a race condition where this can happen and rather than complicate the log rotation code to ensure we never exceed the rotation size, it was deemed simpler to add a little wiggle room in the log threshold check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK we have only seen this in release/2.2 so far - at least in terms of daily runs - so to confirm this is working we may need to repeat running the daos_test/suite.py test or run this in the release/2.2 branch. In either case a detailed examination of the artifact/Functional%20Hardware%20Medium/launch/functional_hardware_medium/*-daos_test-suite-launch.log will be required.

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Bug-tracker data:
Ticket title is 'daos_test/suite.py - One or more /var/tmp/daos_testing/log files exceeded the 2G threshold'
Status is 'In Progress'
Labels: 'triaged'
Errors are Title of PR is too long
https://daosio.atlassian.net/browse/DAOS-12158

@dinghwah dinghwah requested a review from phender December 1, 2022 21:47
@dinghwah dinghwah changed the title DAOS-12158 test: daos_test/suite.py - One or more /var/tmp/daos_testing/*log* files exceeded the 2G threshold DAOS-12158 test: daos_test/suite.py /var/tmp/daos_testing/*log* files exceeded the 2G threshold Dec 1, 2022
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10960/1/execution/node/695/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10960/1/execution/node/785/log

@dinghwah
Update with 2150M
1023602 
Skip-unit-tests: true
Allow-unstable-test: true
Doc-only: false
Test-tag: daos_test
Required-githooks: true
Signed-off-by: Ding Ho [email protected]
daosbuild1
daosbuild1 reviewed Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-10960/2/testReport/(root)/

@dinghwah
Copy link
Contributor Author

dinghwah commented Dec 3, 2022

Original issue fixed with the script changes.

@dinghwah dinghwah requested a review from a team December 5, 2022 21:39
@sylviachanoiyee
Copy link
Contributor

Is the daos test nvme recovery failure in build #2 known?

@dinghwah
Copy link
Contributor Author

dinghwah commented Dec 8, 2022 •
edited
Loading

Yes.
4 daos-test/nvme-recovery test failures are due to known issue DAOS-12039.

@sylviachanoiyee sylviachanoiyee merged commit 2760cda into master Dec 8, 2022
@sylviachanoiyee sylviachanoiyee deleted the dinghwah/DAOS-12158-test branch December 8, 2022 16:25
dinghwah added a commit that referenced this pull request Dec 8, 2022
@dinghwah
DAOS-12158 test: daos_test/suite.py /var/tmp/daos_testing/*log* files…
a156dd8 
… exceeded the 2G threshold (#10960)

Update launch.py DEFAULT_LOGS_THRESHOLD = "2.1G"
Skip-unit-tests: true
Allow-unstable-test: true
Test-tag: daos_test
Required-githooks: true
Signed-off-by: Ding Ho [email protected]
@dinghwah dinghwah mentioned this pull request Dec 8, 2022
Merged
18 tasks
@mjmac mjmac mentioned this pull request Dec 12, 2022
Closed
jolivier23 pushed a commit that referenced this pull request Dec 15, 2022
@dinghwah
DAOS-12158 test: daos_test/suite.py /var/tmp/daos_testing/*log* files…
a3736a2 
… exceeded the 2G threshold (#10960) (#10996)

Update launch.py DEFAULT_LOGS_THRESHOLD = "2.1G"

Signed-off-by: Ding Ho [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@mjean308 mjean308 mjean308 approved these changes

@shimizukko shimizukko shimizukko approved these changes

@phender phender Awaiting requested review from phender

@daltonbohning daltonbohning Awaiting requested review from daltonbohning

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dinghwah @daosbuild1 @sylviachanoiyee @shimizukko @daltonbohning @mjean308 @phender