DAOS-15677 cq: remove required-githooks watermark (#15639)

Since it did not work in all scenarios and the GHA checks are more secure than client-side githooks. Signed-off-by: Dalton Bohning <[email protected]>
daos-stack · Dec 20, 2024 · f85864e · f85864e
1 parent 23fe212
commit f85864e
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 115 deletions.
diff --git a/Jenkinsfile b/Jenkinsfile
@@ -364,25 +364,6 @@ pipeline {
         stage('Check PR') {
             when { changeRequest() }
             parallel {
-                stage('Used Required Git Hooks') {
-                    steps {
-                        catchError(stageResult: 'UNSTABLE', buildResult: 'SUCCESS',
-                                   message: 'PR did not get committed with required git hooks.  ' +
-                                            'Please see utils/githooks/README.md.') {
-                            sh 'if ! ' + cachedCommitPragma('Required-githooks', 'false') + '''; then
-                                   echo 'PR did not get committed with required git hooks.  ' +
-                                        'Please see utils/githooks/README.md.'
-                                   exit 1
-                                fi'''
-                        }
-                    }
-                    post {
-                        unsuccessful {
-                            echo 'PR did not get committed with required git hooks.  ' +
-                                 'Please see utils/githooks/README.md.'
-                        }
-                    }
-                } // stage('Used Required Git Hooks')
                 stage('Branch name check') {
                     when { changeRequest() }
                     steps {

diff --git a/utils/githooks/commit-msg b/utils/githooks/commit-msg
diff --git a/utils/githooks/commit-msg.d/10-watermark.py b/utils/githooks/commit-msg.d/10-watermark.py
diff --git a/utils/githooks/hook_base.sh b/utils/githooks/hook_base.sh
@@ -54,9 +54,3 @@ run-parts() {
 }
 
 run-parts utils/githooks/"${hook}".d "$@" 1>&2
-
-# Create temp file for the commit-msg watermark to indicate this hook was ran.
-# But not for the commit-msg itself.
-if [ "${hook}" != "commit-msg" ]; then
-    touch ".${hook}"
-fi