#112: Cache trimmed only after cache hits #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anuvakkachen Thanks for PR. I gonna take a look soon. |
|
Thanks @danikula |
|
@anuvakkachen , looks good. Can you add unit tests to proof this code works as expected? |
|
@danikula Yes. I can do that. |
danikula
changed the title
|
@anuvakkachen File cache is trimmed every time file is closed. It happen every client disconnection. So library works as expected. These tests proofs it. Also I've played with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new Callable - TrimCallable which only trims cache and not modify last accessed time of file since for cache misses last access time need not be modified manually but will be set automatically after file is fully cached. Used this callable to trim cache when a file is fully cached (100% content available)