Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache is trimmed only after cache hits. #112

Closed
danikula opened this issue Jan 31, 2017 · 1 comment
Closed

Cache is trimmed only after cache hits. #112

danikula opened this issue Jan 31, 2017 · 1 comment
Assignees
@danikula
Labels
bug invalid
Milestone
2.7.0

Comments

@danikula
Copy link
Owner

danikula commented Jan 31, 2017 •
edited
Loading

@anuvakkachen noticed:

There's something I wanted to ask you about this. I noticed that the cache is trimmed only when there's a cache hit. I was wondering whether this is the intended behavior of this cache. It so happens that when I have several consecutive cache misses ,the cache gets full and grows beyond max size until there's a cache hit where upon everything gets trimmed. I might have missed something . Looking forward to hearing from you about this.
@danikula danikula added the bug label Jan 31, 2017
@danikula danikula self-assigned this Apr 18, 2017
@danikula danikula added this to the 2.7.0 milestone Apr 18, 2017
@danikula danikula mentioned this issue Apr 21, 2017
Closed
danikula added a commit that referenced this issue Apr 21, 2017
@danikula
tests for cache trimming (#112, PR 114)
e0ee4a7
@danikula
Copy link
Owner Author

See my explanation

danikula added a commit that referenced this issue Apr 21, 2017
@danikula
#112: touch file to check is cache trimming is required after cache c…
01bba67 
…ompletion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danikula danikula

Labels
bug invalid
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
1 participant
@danikula