Normalize path for Windows #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my Windows machine, `file.absolutePath` and `imagePath` were not matching because the former had forward slashes and the later backward slashes. This might fix #2.
|
@axelboc good catch! thanks for the PR, I am also adding normalize to the markdown node sections |
danielmahon
added a commit
that referenced
this pull request
Jun 13, 2018
…ves pr #3 Signed-off-by: Daniel Mahon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my Windows machine,
file.absolutePathandimagePathwere not matching because the former had forward slashes and the latter backward slashes. This might fix #2.Thanks a lot for this awesome plugin, by the way; this issue was a real blocker for me! I hope the Gatsby team comes up with a solution soon.