Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document required Netlify CMS configuration #4

Closed
axelboc opened this issue Jun 13, 2018 · 2 comments
Closed

Document required Netlify CMS configuration #4

axelboc opened this issue Jun 13, 2018 · 2 comments

Comments

@axelboc
Copy link
Contributor

axelboc commented Jun 13, 2018

If I'm not mistaken, the plugin assumes that the configured Netlify CMS public_folder is one level down from the media_folder - e.g.

media_folder: "static/uploads"
public_folder: "/uploads"

I'm referring more specifically to line 129:

imagePath = path.join(file.dir, '..', value);

If that's the case, it might be worth mentioning it in the README.

@danielmahon
Copy link
Owner

@axelboc I think you're right, probably better to use path.basename rather than jumping up a level.

@axelboc
Copy link
Contributor Author

axelboc commented Jun 13, 2018

Ah yeah, great solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants