feat: Support for storing passkeys in the vault

[GeekCornerGH]

Implements the ability to store passkeys in the vault

How to test

1. Checkout this branch, then install dependencies with npm i (npm ci didn't worked, where npm i somehow worked in my case)
2. Enable feature flag for the extension. As I didn't figured out how to do this properly, I changed the values there and there to make them always return true
3. Follow the docs to build and install the modified extension in your browser (I installed it in a custom profile)
4. Go to a website supporting passkeys. I used passkeys.io, and also tested against webauthn.io but any website supporting webauthn should actually work, then register your key

Demo

0t3iC11yBS.mp4

Notes

Upstream PR: bitwarden/server#2679
Tested on Brave 1.54.65 Chromium: 114.0.5735.133 (Official build) nightly (64 bits)
The feature isn't released yet, but there shouldn't be any big changes as Vaultwarden doesn't type the properties of ciphers the way upstream server does

[meowcoder]

2. Enable feature flag for the extension. As I didn't figured out how to do this properly

The extension queries the /api/config endpoint for this.
One can enable passkeys like this:

diff --git a/src/api/core/mod.rs b/src/api/core/mod.rs
index f142468..2e50870 100644
--- a/src/api/core/mod.rs
+++ b/src/api/core/mod.rs
@@ -200,6 +200,9 @@ fn config() -> Json<Value> {
           "name": "Vaultwarden",
           "url": "https://github.com/dani-garcia/vaultwarden"
         },
+        "featureStates": {
+            "fido2-vault-credentials": true
+        },
         "environment": {
           "vault": domain,
           "api": format!("{domain}/api"),

[stefan0xC]

@meowcoder I don't think that's enough because this feature has not even been merged yet upstream. See bitwarden/server#2679 and bitwarden/clients#4715

And because Bitwarden has changed their passkey implementation from it's own item type to a login item field (c.f. bitwarden/server#3261) we also have to update our implementation as well.

In general, I don't think that we should enable features before they are stable.

[ItsShadowCone]

Upstream support has been released, so should be stable now: see #3355

What's necessary to get there for vaultwarden too?

[agelwarg]

Upstream support has been released, so should be stable now: see #3355

What's necessary to get there for vaultwarden too?

Also looks like the updates to the clients / browser extensions have been rolled out as well (just updated on my iPhone) and it works (against upstream, not Vaultwarden).

[GeekCornerGH]

Working on a new PR

[adriy-be]

I retried today and that work now. Thanks for your work ! 😁

Hi, I have updated my docker file to testing tag. But It's not working on brave.
There is diagnostics of vaultwarden:
Server Installed: 1.29.2-93da5091
Server Latest: 1.29.2-93da5091
Web Installed: 2023.10.0

And my extension:
version : 2023.10.0
Server version: 1.29.2

Brave version:
[Version 1.60.110 Chromium: 119.0.6045.105 (Official Build) (64-bit)]

The message I have got when I try: