[PM-1222] Passkeys in the Bitwarden vault #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
gbubemismith
reviewed
May 3, 2023
There was a problem hiding this comment.
This looks good to me; I just added a suggestion. Thanks, @coroiu
| @@ -164,6 +168,7 @@ private CipherLoginData ToCipherLoginData() | |||
| PasswordRevisionDate = Login.PasswordRevisionDate, | |||
| Totp = Login.Totp, | |||
| AutofillOnPageLoad = Login.AutofillOnPageLoad, | |||
| Fido2Key = Login.Fido2Key == null ? null : Login.Fido2Key.ToCipherLoginFido2KeyData(), | |||
There was a problem hiding this comment.
Would this be cleaner if we use the shorthand?
Fido2Key = Login.Fido2Key?.ToCipherLoginFido2KeyData();
* Added feature flag to enable pass keys * Renamed enable pass keys to fido2 vault credentials
|
No New Or Fixed Issues Found |
trmartin4
changed the title
* PM-1859 Refactor to credentialId * PM-1859 Removed unnecessary import --------- Co-authored-by: Andreas Coroiu <[email protected]>
* [PM-3807] feat: add discoverable property to fido2key * [PM-3807] feat: remove standalone Fido2Key * [PM-3807] chore: clean up unusued constant * [PM-3807] fix: remove standadlone Fido2Key property that I missed
* [PM-3807] feat: store passkeys in array * [PM-3807] amazing adventures with the c# linter
* Added creationDate property to the Fido2Key object * Fixed lint issues * fixed comments * made createionDate required
…ty (#3262) * [PM-3807] feat: add discoverable property to fido2key * [PM-3807] feat: remove standalone Fido2Key * [PM-3807] chore: clean up unusued constant * [PM-3808] feat: add fido2 compatibility check before saving ciphers * Resolved merge conflicts. * Setting minimum version for QA. --------- Co-authored-by: Todd Martin <[email protected]>
…g with org (#3328) * Added compatibility checks. * Refactored into separate methods for easier removal. * Added check on ShareMany * Updated method order to be consistent. * Linting
… feature on for self-hosted.
shane-melton
requested changes
Oct 16, 2023
shane-melton
approved these changes
Oct 17, 2023
trmartin4
deleted the
EC-598-beeep-properly-store-passkeys-in-bitwarden
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Introduces the ability to store Passkeys in the Bitwarden vault.
The functionality is behind the
fido2-vault-credentialsfeature flag.This PR represents the current state of the long-lived feature branch. Since we have a feature flag, we are introducing these changes to
masterbefore the feature is complete. The remaining work in https://bitwarden.atlassian.net/browse/PM-1222 will be introduced in a subsequent, separate PR.Depends on bitwarden/clients#4715
Code changes
Before you submit
dotnet format --verify-no-changes) (required)