Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include step comments in report #1012

Conversation

jfougere
Copy link
Contributor

This PR fixes #828 by parsing comments from JSON file and displaying above steps.

For Karate users, another ticket is opened to include comments in those JSON file, see karatelabs/karate#1677

@damianszczepanik
Copy link
Owner

Add sample comments into sample.json so then it is visible at http://damianszczepanik.github.io/cucumber-html-reports/overview-features.html
Add integration tests that examines new field. I believe you can take as a reference many of them as they are delivered

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2021

Codecov Report

Merging #1012 (784acc1) into master (edc75f9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1012   +/-   ##
=========================================
  Coverage     97.16%   97.17%           
- Complexity      546      547    +1     
=========================================
  Files            54       54           
  Lines          1200     1202    +2     
  Branches        103      103           
=========================================
+ Hits           1166     1168    +2     
  Misses           20       20           
  Partials         14       14           
Impacted Files Coverage Δ
...ain/java/net/masterthought/cucumber/json/Step.java 94.59% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc75f9...784acc1. Read the comment docs.

@jfougere
Copy link
Contributor Author

@damianszczepanik done. Please review

@jfougere
Copy link
Contributor Author

Hi @damianszczepanik could you have another look to this PR ? thanks

@jfougere
Copy link
Contributor Author

Hi @damianszczepanik could you have another look to this PR ? thanks

@jfougere
Copy link
Contributor Author

Hi @damianszczepanik could you review again ? For me all remarks have been taken into account.
Thanks

@damianszczepanik damianszczepanik merged commit 56b81f1 into damianszczepanik:master Aug 17, 2021
@damianszczepanik
Copy link
Owner

Good job!

@jfougere jfougere deleted the feature/support-step-comments branch August 30, 2021 02:31
@jfougere
Copy link
Contributor Author

@damianszczepanik I see you did the release in 5.6.0. That's great thanks.

Could you also do a new release of https://github.com/jenkinsci/cucumber-reports-plugin with 5.6.0 version of the library ?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate feature comments in the cucumber reporting
3 participants