-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include step comments in report #1012
Include step comments in report #1012
Conversation
…nd displaying above steps.
Add sample comments into sample.json so then it is visible at http://damianszczepanik.github.io/cucumber-html-reports/overview-features.html |
Codecov Report
@@ Coverage Diff @@
## master #1012 +/- ##
=========================================
Coverage 97.16% 97.17%
- Complexity 546 547 +1
=========================================
Files 54 54
Lines 1200 1202 +2
Branches 103 103
=========================================
+ Hits 1166 1168 +2
Misses 20 20
Partials 14 14
Continue to review full report at Codecov.
|
@damianszczepanik done. Please review |
Hi @damianszczepanik could you have another look to this PR ? thanks |
...ava/net/masterthought/cucumber/generators/integrations/FeatureReportPageIntegrationTest.java
Show resolved
Hide resolved
src/test/java/net/masterthought/cucumber/generators/integrations/helpers/StepAssertion.java
Show resolved
Hide resolved
Hi @damianszczepanik could you have another look to this PR ? thanks |
Hi @damianszczepanik could you review again ? For me all remarks have been taken into account. |
Good job! |
@damianszczepanik I see you did the release in 5.6.0. That's great thanks. Could you also do a new release of https://github.com/jenkinsci/cucumber-reports-plugin with 5.6.0 version of the library ? |
This PR fixes #828 by parsing comments from JSON file and displaying above steps.
For Karate users, another ticket is opened to include comments in those JSON file, see karatelabs/karate#1677