Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate feature comments in the cucumber reporting #828

Closed
ouquoi opened this issue Apr 2, 2019 · 7 comments · Fixed by #1012
Closed

Integrate feature comments in the cucumber reporting #828

ouquoi opened this issue Apr 2, 2019 · 7 comments · Fixed by #1012

Comments

@ouquoi
Copy link

ouquoi commented Apr 2, 2019

Is there a way to add the comment in feature file to the html report ?
Thanks for your help.

@damianszczepanik
Copy link
Owner

Do you have sample JSON report with comments? Attach for reference

@damianszczepanik
Copy link
Owner

Closing as no feedback so far.

@jfougere
Copy link
Contributor

jfougere commented Jul 7, 2021

Hi @damianszczepanik just found this issue. I am actually looking for this feature also.

Below is an example of the json genrated by karate and which are the inputs for the cucumber reporting:

"step": {
            "comments": [
              "# Step 1: Subscribe to product"
            ],
           ....
          },

Such comment are present in the Karate reporting but I'd like to have such comments in the cucumber report.

Do you think this could be done ? It would be nice to have a display similar to feature descriptions.

@damianszczepanik
Copy link
Owner

Would be nice. You can prepare PR if you like so I can help

@jfougere
Copy link
Contributor

Hi @damianszczepanik my bad in fact Karate make those comments available only for the json produce for its own report but not for the json used as input for cucumber reporting.

Locally I prepared two changes one on Karate to add the comments and one on cucumber-reporting to use them and it works good.

The result looks like this:
Capture d’écran 2021-07-10 à 08 43 27

So I will try on Karate side to see if they are open for a PR to add comments on the produced json.

@fslev
Copy link

fslev commented Oct 11, 2021

Sorry but I do not agree with this feature.
What will happen if Cucumber will add their own feature for generating comments inside the JSON report ? This is a Cucumber Report library and not a Karate report library.

@damianszczepanik
Copy link
Owner

Then we will decide what to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants