Correct naming of com_github_lyft_protoc_gen_star go_repository (envo…

…yproxy#31169) Similar to bufbuild/protoc-gen-validate#900 correct naming should include the major version. https://go.dev/ref/mod#module-path If the module is released at major version 2 or higher, the module path must end with a major version suffix like /v2. This may or may not be part of the subdirectory name. For example, the module with path golang.org/x/repo/sub/v2 could be in the /sub or /sub/v2 subdirectory of the repository golang.org/x/repo. So go_repository stanza also should include the major version, to distinguish between the different major versions of the module, that can coexist. Signed-off-by: Alex Bozhenko <[email protected]>
daixiang0 · Dec 11, 2023 · 8c5720f · 8c5720f
1 parent a11ce96
commit 8c5720f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/bazel/dependency_imports.bzl b/bazel/dependency_imports.bzl
@@ -125,7 +125,7 @@ def envoy_dependency_imports(go_version = GO_VERSION, jq_version = JQ_VERSION, y
         # source = "https://github.com/bufbuild/protoc-gen-validate/blob/v0.6.1/dependencies.bzl#L60-L65"
     )
     go_repository(
-        name = "com_github_lyft_protoc_gen_star",
+        name = "com_github_lyft_protoc_gen_star_v2",
         importpath = "github.com/lyft/protoc-gen-star/v2",
         sum = "h1:keaAo8hRuAT0O3DfJ/wM3rufbAjGeJ1lAtWZHDjKGB0=",
         version = "v2.0.1",