Correct naming of com_github_lyft_protoc_gen_star go_repository

[alexbozhenko]

Commit Message:Correct naming of com_github_lyft_protoc_gen_star go_repository
Additional Description:
Similar to bufbuild/protoc-gen-validate#900
correct naming should include the major version.

https://go.dev/ref/mod#module-path

If the module is released at major version 2 or higher, the module path must end with a major version suffix like /v2. This may or may not be part of the subdirectory name. For example, the module with path golang.org/x/repo/sub/v2 could be in the /sub or /sub/v2 subdirectory of the repository golang.org/x/repo.

So go_repository stanza also should include the major version, to distinguish between the different major versions of the module, that can coexist.

After the change, the naming is consistent:

$ rg 'com_github_lyft_protoc_gen_star'
bazel/dependency_imports.bzl
128:        name = "com_github_lyft_protoc_gen_star_v2",

api/bazel/repository_locations.bzl
27:            "com_github_lyft_protoc_gen_star_v2",

Risk Level: None
Testing: CI passes...?
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Alex Bozhenko [email protected]

[repokitteh-read-only]

Hi @alexbozhenko, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #31169 was opened by alexbozhenko.

see: more, trace.

[repokitteh-read-only]

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @htuch

🐱

Caused by: #31169 was opened by alexbozhenko.

see: more, trace.

[alexbozhenko]

@fishcakez @JuniorHsu

[htuch]

Seems fine, but maybe I'm a bit dense - how does the Bazel internal name matter?

[alexbozhenko]

@htuch: we have a setup where we import this repo and use envoy_dependency_imports from this repo. On top of that, we have some extra go code, that also has a dependency on protoc_gen_star, but on v1 of it. Because the names of those two go_repositroes are the same, we have a conflict, similar to what I described at bufbuild/protoc-gen-validate#900

[htuch]

OK, seems harmless and technically right.

[alexbozhenko]

/retest

[phlax]

@alexbozhenko unfortunately we have just updated our ci framework so /retest wont work to resolve - you will need to merge main