Quote tab completion items with PS special chars. #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we merge this for 0.7.0, don't forget to update CHANGELOG.md. |
dahlbyk
requested changes
Feb 13, 2017
src/GitTabExpansion.ps1
Outdated
| @@ -51,6 +51,15 @@ catch { | |||
| Write-Debug "Search for 'flow' in 'git help' output failed with error: $_" | |||
| } | |||
|
|
|||
| filter quoteStringWithSpecialChars { | |||
| if ($_ -and ($_ -match '\s+|#|@|\$|;|\{|\}|\(|\)')) { | |||
| "'" + $_ + "'" | |||
There was a problem hiding this comment.
- Why not
"'$_'"? - We should also handle values that include
'.
src/GitTabExpansion.ps1
Outdated
| @@ -51,6 +51,15 @@ catch { | |||
| Write-Debug "Search for 'flow' in 'git help' output failed with error: $_" | |||
| } | |||
|
|
|||
| filter quoteStringWithSpecialChars { | |||
| if ($_ -and ($_ -match '\s+|#|@|\$|;|\{|\}|\(|\)')) { | |||
| $result | Should BeExactly $fileName | ||
| } | ||
| } | ||
|
|
||
| Context 'PowerShell Special Chars Tests' { | ||
| BeforeAll { |
There was a problem hiding this comment.
This is bound to be a pretty common pattern. Is it possible to write a Pester helper that would encapsulate a BeforeAll/AfterAll pairing that initializes and cleans up a Git repo, with its path left in $repoPath? Something like:
Context 'Awesome test' {
TempRepo {
# Set up the repo
}
It 'Uses $repoPath' {
# ...
}
}
I don't know that Pester will support a user-defined construct to encapuslate BeforeAll/AfterAll. But I did pull the guts out into shared functions.
|
I think I've addressed all of the issues except the last one the Pester helper. That said, I did move common code into reusable functions (in Shared.ps1). |
dahlbyk
approved these changes
Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #293