Tab expansion starting with '#' needs to be escaped

[Morten242]

When using tab-expansion on branch-names, if they start with '#' then it, and the rest of the line will get ignored by powershell since '#' marks the start of a line comment. Escaping it with ` does help though, e.g.:

git checkout#1-branch-name
`

This is only necessary when the name starts with the pound-sign though, as names like feature/#1-branch-name works fine without any escaping.

[dahlbyk]

This applies to any string that starts with #. More generally, it seems like we would do well to have a generic "quote tab completed value" filter that handles any string that looks like PowerShell might get confused (e.g. stash refs).

For the record, you can either escape (`#branch) or quote ('#branch') these strings.

[rkeithhill]

Yup, # is a special char in PoweShell (comment). There are a number of special characters most of which are punctuation like $, @, (, {, ;.

[dahlbyk]

And Git supports branches starting with all of them:

[rkeithhill]

PowerShell will automatically quote paths during tab expansion that contain special chars or spaces. I'm guessing we could do something similar when tab expanding branch names. How about remote names? Can you have special chars in remote names as well?

[dahlbyk]

Can you have special chars in remote names as well?

Yep. I'm inclined to add a guard against special characters in any tab completed string.

[rkeithhill]

@dahlbyk There are some tab completed strings that are already escaped via single quotes (stashes and TF shelvesets).

[lzybkr]

@rkeithhill - I think I've solved this problem completely in TabExpansionPlusPlus, see https://github.com/lzybkr/TabExpansionPlusPlus/blob/master/TabExpansionPlusPlus.psm1#L64 - feel free to take that code as you see fit (I guess V3 and beyond only).