Skip to content

Commit

Permalink
fix: remove options structs in go sdk (#5907)
Browse files Browse the repository at this point in the history
* test: add tests to verify passing slice and pointer types

Signed-off-by: Justin Chadwell <[email protected]>

* fix: fix variadic args for go sdk functions

Signed-off-by: Justin Chadwell <[email protected]>

* feat: remove opt structs in go sdk

See the full PR for more info - but essentially, determining "opt"iness
is difficult: doing by pointer is weird, doing with names feels too
magic, etc.

So we just remove the feature and now support two different ways of
passing opts:
- As individual args directly
- As inline structs

Signed-off-by: Justin Chadwell <[email protected]>

* docs: update zenith docs to not use Opts structs

Signed-off-by: Justin Chadwell <[email protected]>

* fix: resolve code review comments

Signed-off-by: Justin Chadwell <[email protected]>

---------

Signed-off-by: Justin Chadwell <[email protected]>
  • Loading branch information
jedevc authored Oct 25, 2023
1 parent 2372753 commit 5d66de6
Showing 1 changed file with 36 additions and 0 deletions.
36 changes: 36 additions & 0 deletions dagger.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 5d66de6

Please sign in to comment.