Skip to content

Commit

Permalink
core: fix huge module/func IDs by removing Function.call (#5947)
Browse files Browse the repository at this point in the history
* core: fix huge module/func IDs by removing Function.call

We are hitting some problems with IDs growing to enormous size and
exceeding gRPC messages limits in relatively normal cases (i.e. 13
functions defined in a module).

I didn't fully track down exactly what was happening, but suspected that
it was related to the annoyance we were dealing with internally to store
ModuleID on the Function object.

That annoyance only existed in order to support the Function.call
"dynamic" API. That API isn't actually used anywhere right now, so I just
tried removing that API call and the associated ModuleID handling in
Function and sure enough the problem w/ huge IDs went away.

This feels like the best solution for now. If a request for the
Function.call API arises in the future it can be re-added but rather
than adding it to the Function object, it can be put on the Module
object (and just require object+func name in addition to existing args),
which should avoid the problem we're hitting now.

Signed-off-by: Erik Sipsma <[email protected]>

* regen sdks

Signed-off-by: Erik Sipsma <[email protected]>

* remove unused Function.ParentName field

Signed-off-by: Erik Sipsma <[email protected]>

---------

Signed-off-by: Erik Sipsma <[email protected]>
  • Loading branch information
sipsma authored Oct 23, 2023
1 parent bebf8a2 commit 2372753
Showing 1 changed file with 0 additions and 39 deletions.
39 changes: 0 additions & 39 deletions dagger.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2372753

Please sign in to comment.