Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: type for the Outputs removed and made it map[string]any to have better support in templates #1594

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Jul 3, 2024

fix for #1487.

Before it usage of the dig template function resulted in an internal error due to a type conversation issue.

@dadrus dadrus changed the title chore: type for the Outputs removed and made it map[string]any to have better support in templates chore: type for the Outputs removed and made it map[string]any to have better support in templates Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.59%. Comparing base (4475745) to head (05d4c29).
Report is 1 commits behind head on main.

Files Patch % Lines
...nal/handler/envoyextauth/grpcv3/request_context.go 0.00% 2 Missing ⚠️
internal/handler/requestcontext/request_context.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1594      +/-   ##
==========================================
- Coverage   89.63%   89.59%   -0.04%     
==========================================
  Files         272      271       -1     
  Lines        9012     9008       -4     
==========================================
- Hits         8078     8071       -7     
- Misses        696      697       +1     
- Partials      238      240       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dadrus dadrus merged commit 8e4d74b into main Jul 3, 2024
27 checks passed
@dadrus dadrus deleted the chore/outputs_fix branch July 3, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant