-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Subject has been made immutable #1487
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/rules/mechanisms/contextualizers/generic_contextualizer_test.go
Outdated
Show resolved
Hide resolved
internal/rules/mechanisms/contextualizers/generic_contextualizer_test.go
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1487 +/- ##
=======================================
Coverage 89.62% 89.63%
=======================================
Files 270 271 +1
Lines 9051 9075 +24
=======================================
+ Hits 8112 8134 +22
- Misses 694 699 +5
+ Partials 245 242 -3 ☔ View full report in Codecov by Sentry. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
addresses #1317
Prepares the code to support pre-authentication stages
Checklist
Description
This PR introduces a breaking change and makes the
Subject
object immutable. That means it is not used to store results of any pipeline step any more. A newOutputs
object has been introduced for that purpose instead.Old Behavior
New Behavior