Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Service Naming docs improvement #168

Open
mhausenblas opened this issue Jun 8, 2015 · 5 comments
Open

Service Naming docs improvement #168

mhausenblas opened this issue Jun 8, 2015 · 5 comments

Comments

@mhausenblas
Copy link

The Mesos-DNS Service Naming doc doesn't explain how groups in Marathon are translated. Since this question comes up more often, for example on IRC, the doc should answer this pro-actively, potentially including pointing out the algorithm.

@bhenderson
Copy link

for posterity,

/group/app -> app-group.marathon.mesos worked for me

@jdef
Copy link
Contributor

jdef commented Nov 16, 2015

Can you provide a specific example of a /group-name/app-name that's failing
to translate properly for you?

On Mon, Nov 16, 2015 at 11:55 AM, UndeadBaneGitHub <[email protected]

wrote:

It is not working properly for task names, that have hyphens.
/group/app properly translates into app-group.marathon.mesos
But /group/app-name or /group-name/app or, of course, /group-name/app-name
do not seem to translate properly.


Reply to this email directly or view it on GitHub
#168 (comment)
.

@UndeadBaneGitHub
Copy link

This turned out to be an issue of length and truncation - I overlooked the
24 symbols length limitation.
But that raises another problem: if there are several groups-in-groups with
more or less long names, the truncation creates a possibility of different
services being considered one. Here is an example:
"/group-name-a/subgroup-name-a/app" and "/group-name-a/subgroup-name-a/app"
would get truncated to the same "app-subgroup-name-a-grou.marathon.mesos".
While it's a different issue, shouldn't the behavior be revised, and dots
left untouched for groups?

On Tuesday, 17 November 2015, James DeFelice [email protected]
wrote:

Can you provide a specific example of a /group-name/app-name that's failing
to translate properly for you?

On Mon, Nov 16, 2015 at 11:55 AM, UndeadBaneGitHub <
[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');

wrote:

It is not working properly for task names, that have hyphens.
/group/app properly translates into app-group.marathon.mesos
But /group/app-name or /group-name/app or, of course,
/group-name/app-name
do not seem to translate properly.


Reply to this email directly or view it on GitHub
<
https://github.com/mesosphere/mesos-dns/issues/168#issuecomment-157096074>
.


Reply to this email directly or view it on GitHub
#168 (comment)
.

@jdef
Copy link
Contributor

jdef commented Nov 16, 2015

yes we should revise. hence #145

@luiseduardobrito
Copy link

+1 @fbidu

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants