Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

record generation is too aggressive w/ respect to tasks with dots in their name #145

Closed
jdef opened this issue May 1, 2015 · 5 comments
Closed
Assignees
Labels

Comments

@jdef
Copy link
Contributor

jdef commented May 1, 2015

for example, marathon will create tasks for deployment groups with names like a.b.c or member.team.org. currently the dns952 label package converts these dots to dashes. for example, a a task named "a.b.c" is transformed to "a-b-c". this facilitates SRV record construction based on task name such that task a.b.c has an srv record of _a-b-c._tcp.{some-domain-suffix}.

@ConnorDoyle says that a better transformation would generate an srv record named _a._tcp.b.c.{some-domain-suffix}. this would preserve the naming hierarchy established by the framework. it also allows each framework to be responsible for the uniqueness of task names, instead of clobbering the task name in transformation like we currently do.

@kozyraki what are your thoughts?

@kozyraki
Copy link
Contributor

kozyraki commented May 2, 2015

I don't think it's worth putting much effort in the current naming scheme. We should put more thought in the naming scheme proposed using the discovery info. Look at the google doc and make comments. Stefan is just starting with it.

On May 1, 2015, at 6:13 PM, James DeFelice [email protected] wrote:

for example, marathon will create tasks for deployment groups with names like a.b.c or member.team.org. currently the dns952 label package converts these dots to dashes. for example, a a task named "a.b.c" is transformed to "a-b-c". this facilitates SRV record construction based on task name such that task a.b.c has an srv record of _a-b-c._tcp.{some-domain-suffix}.

@ConnorDoyle says that a better transformation would generate an srv record named _a._tcp.b.c.{some-domain-suffix}. this would preserve the naming hierarchy established by the framework. it also allows each framework to be responsible for the uniqueness of task names, instead of clobbering the task name in transformation like we currently do.

@kozyraki what are your thoughts?


Reply to this email directly or view it on GitHub.

@kozyraki
Copy link
Contributor

@jdef I think long term we will be fine because users will be able to configure naming.

Short term, we have a few choices:

  • leave it as is for now
  • take back the conversion of "." to "-". To avoid confusion, we can roll out the _ep name for the service now, rather than later.

Opinions?

@tsenart
Copy link
Contributor

tsenart commented Aug 11, 2015

Link #230

@jdef
Copy link
Contributor Author

jdef commented Oct 21, 2015

xref #168

@jdef
Copy link
Contributor Author

jdef commented Jul 12, 2017

not sure that we can actually change the name generation scheme at this point w/o breaking TONS of people, therefore closing this out

@jdef jdef closed this as completed Jul 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants